Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CODEOWNERS #1367
Remove CODEOWNERS #1367
Changes from all commits
0541f02
fff60a7
9d5bbbe
f9658a7
1d03435
9d48ed3
590769f
1de2685
30004ed
1997e93
c9ba02f
02a6fad
b6da58b
dc78d63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to suggest this? I've not really seen people using it recently, and my experience trying it previously was not all that pleasant -- to the point that I find I prefer to delay reviews of dependent changes until the base change lands. It also seems exclusionary to provide a different workflow for people with commit access versus everyone else, especially if we do not intend for commit access to be granted to all regular contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd support removing it, but IIRC @chandlerc added it so it may be best to discuss with him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, remove it. It just doesn't work. I've switched to just documenting in stacked PRs which commit range to look at and giving up once merges are occuring.