Code

Design direction for sum types#157

Code

Merged

geoffromer merged 29 commits intocarbon-language:trunkcarbon-language/carbon-lang:trunkfrom geoffromer:directionCopy head branch name to clipboardFeb 10, 2021

+1,061

Commits

Commits on Sep 8, 2020

• Initial draft of "Design direction for sum types"

  geoffromer

  committed
  a873000

  Copy full SHA for a873000

• Move proposal to numbered file

  geoffromer

  committed
  483166f

  Copy full SHA for 483166f

Commits on Sep 11, 2020

• Respond to review comments and other feedback.

  geoffromer

  committed
  ab67a8e

  Copy full SHA for ab67a8e

• Minor cleanup of FIXMEs

  geoffromer

  committed
  e536993

  Copy full SHA for e536993

Commits on Sep 15, 2020

• Respond to reviewer comments.

  geoffromer

  committed
  7783cb6

  Copy full SHA for 7783cb6

Commits on Sep 25, 2020

• Switch proposal to make conversion to StorageArray explicit, and consequently switch to using Array(Storage) instead of StorageArray

  geoffromer

  committed
  6cab1d9

  Copy full SHA for 6cab1d9

Commits on Oct 30, 2020

• Extensive overhaul of sum types proposal:

  Show description for a428835
  geoffromer

  committed
  a428835

  Copy full SHA for a428835

• Respond to reviewer feedback.

  geoffromer

  committed
  2431758

  Copy full SHA for 2431758

Commits on Nov 2, 2020

• Apply suggestions from code review

  Show description for 4cdb352
  

  geoffromer

  and

  josh11b

  authored
  4cdb352

  Copy full SHA for 4cdb352

Commits on Nov 3, 2020

• Respond to reviewer comments.

  geoffromer

  committed
  b00255a

  Copy full SHA for b00255a

Commits on Nov 12, 2020

• Switch Storage to represent whole buffers, not individual bytes. Also, explicitly discuss some issues that the OptionalPtr example was fudging, and mention the issue of choice alternative param…

  Show description for 47d627e
  geoffromer

  committed
  47d627e

  Copy full SHA for 47d627e

• Explain how special members can be generated automatically.

  geoffromer

  committed
  60d00d1

  Copy full SHA for 60d00d1

• Respond to reviewer comments

  geoffromer

  committed
  c1c08f1

  Copy full SHA for c1c08f1

Commits on Nov 13, 2020

• Draft discussion of "Pattern matching proxies" alternative.

  geoffromer

  committed
  0afe466

  Copy full SHA for 0afe466

Commits on Nov 17, 2020

• Initial sketch of callback-based approach

  geoffromer

  committed
  80bac79

  Copy full SHA for 80bac79

Commits on Dec 1, 2020

• Discuss callback-based approach in depth, and focus on it as the leading alternative. Also add discussion of binding patterns that mutate in-place.

  geoffromer

  committed
  026aba8

  Copy full SHA for 026aba8

• Respond to reviewer comments, and delete redundant/inaccurate discussion of "explicit inverses"

  geoffromer

  committed
  4dbd31d

  Copy full SHA for 4dbd31d

Commits on Dec 14, 2020

• Pivot to make "Pattern matching callbacks" the primary proposal, and move reference semantics to "open question" status.

  geoffromer

  committed
  bdaac53

  Copy full SHA for bdaac53

• Respond to reviewer comment.

  geoffromer

  committed
  8b8fb3a

  Copy full SHA for 8b8fb3a

Commits on Jan 11, 2021

• Respond to reviewer comments.

  geoffromer

  committed
  6010589

  Copy full SHA for 6010589

• Apply suggestions from code review

  Show description for 581267c
  

  geoffromer

  and

  josh11b

  authored
  581267c

  Copy full SHA for 581267c

Commits on Jan 14, 2021

• Respond to reviewer comments

  geoffromer

  committed
  8ffcba5

  Copy full SHA for 8ffcba5

Commits on Jan 18, 2021

• Add discussion of how to distinguish patterns from expressions, and move the discussion of bare designators to integrate better with it.

  geoffromer

  committed
  9e1ba63

  Copy full SHA for 9e1ba63

• Expand the discussion of the drawbacks of the "Designator types" approach.

  geoffromer

  committed
  0e988ef

  Copy full SHA for 0e988ef

Commits on Jan 21, 2021

• Respond to reviewer comments.

  geoffromer

  committed
  e14d693

  Copy full SHA for e14d693

• Respond to reviewer comments.

  geoffromer

  committed
  e4bb86d

  Copy full SHA for e4bb86d

Commits on Feb 3, 2021

• Respond to reviewer comments

  geoffromer

  committed
  2ab98c2

  Copy full SHA for 2ab98c2

Commits on Feb 10, 2021

• Merge branch 'trunk' into direction

  geoffromer

  committed
  875d8cf

  Copy full SHA for 875d8cf

• Fix presubmit failure.

  geoffromer

  committed
  468a65a

  Copy full SHA for 468a65a