Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decision for: Basic Syntax #162 #190

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Decision for: Basic Syntax #162 #190

merged 3 commits into from
Dec 1, 2020

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Nov 10, 2020 •
edited
Loading

Tracking issues filed as part of decision:

Finalized on 2020-11-24

@jonmeow jonmeow added the proposal accepted Decision made, proposal accepted label Nov 10, 2020
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Nov 10, 2020
@jonmeow jonmeow mentioned this pull request Nov 10, 2020
Merged
jsiek
jsiek approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@jsiek jsiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news!

@jonmeow jonmeow requested review from a team and chandlerc and removed request for chandlerc November 10, 2020 23:58
chandlerc
chandlerc approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonmeow jonmeow merged commit 5b00a92 into carbon-language:trunk Dec 1, 2020
@jonmeow jonmeow deleted the decision-162 branch December 1, 2020 21:19
@zygoloid zygoloid mentioned this pull request Feb 24, 2022
Merged
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow
Decision for: Basic Syntax #162 (#190)
1a85ea2 
- [Proposal PR](#162)
- [RFC topic](https://forums.carbon-lang.dev/t/rfc-basic-syntax/142)
- [Decision request](https://forums.carbon-lang.dev/t/request-for-decision-basic-syntax-162/165)
- [Decision announcement](https://forums.carbon-lang.dev/t/accepted-basic-syntax-162/170)

Tracking issues filed as part of decision:

- Should there be a function type? #191
- Should types be values? #192

Finalized on 2020-11-24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsiek jsiek jsiek approved these changes

@chandlerc chandlerc chandlerc approved these changes

@sidney13 sidney13 Awaiting requested review from sidney13

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonmeow @chandlerc @jsiek