Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for wiki change notifications. #2089

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 22, 2022

Wiki can either be "require push access" or "everyone" -- apparently there's no other option. I've set it to "everyone" so that contributors can make edits without needing push access. So the options as I see it are:

  • Leave wiki as "everyone" can edit, use this for notifications.
    • GitHub doesn't give notifications for wiki edits. This is trying a different approach for notifications.
  • Grant push access to a larger group (contributors), don't add CODEOWNERS.
    • Not sure this is the right choice because of the implications around merges, but again maybe it'd be fine and we can expect the approval requirement to work out.
  • Grant push access to contributors, add CODEOWNERS.
  • Create a separate wiki repo so that we can differently handle push access.
    • This seems overly complex a solution though.

I'm hoping this approach works.

(note, I haven't set up the webook yet, wanted agreement on trying the approach first)

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy starting with this approach. We can see how it goes.

.github/workflows/discord_wiki.yaml Show resolved Hide resolved
@jonmeow jonmeow merged commit ed3a81a into carbon-language:trunk Aug 23, 2022
@jonmeow jonmeow deleted the wiki-discord branch August 23, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants