Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Variadics #2240

Open
wants to merge 77 commits into
base: trunk
Choose a base branch
from
Open

Proposal: Variadics #2240

wants to merge 77 commits into from
+2,092 −10

Commits on Sep 30, 2022

  1. In-progress draft variadics proposal

    @geoffromer
    geoffromer committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    c696fd5 View commit details
    Browse the repository at this point in the history

  2. Major overhaul/cleanup (still WIP)

    @geoffromer
    geoffromer committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    732db47 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @geoffromer
    geoffromer committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    829dbd3 View commit details
    Browse the repository at this point in the history

  4. Add overview and some notes to reader

    @geoffromer
    geoffromer committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    49cba67 View commit details
    Browse the repository at this point in the history

  5. Update with proposal number

    @geoffromer
    geoffromer committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    a772441 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Clarfifications based on early feedback

    @geoffromer
    geoffromer committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    12152d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Respond to reviewer comments

    @geoffromer
    geoffromer committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    db5cf06 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Add example that uses the result of deduction.

    @geoffromer
    geoffromer committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d32f4d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Redesign typechecking tuple patterns 

    Based on https://docs.google.com/document/d/1C55EFcyRQ4ybexz_M5DdAdi924qLGPAKI9m8svj9CA8/edit?usp=sharing&resourcekey=0-mTLBc3kLXd1yIMQBTXvzBw
    @geoffromer
    geoffromer committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b398e20 View commit details
    Browse the repository at this point in the history

  2. Make Min a checked genericxsx

    @geoffromer
    geoffromer committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7d3b693 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    128bdc5 View commit details
    Browse the repository at this point in the history

  2. Respond to reviewer comments

    @geoffromer
    geoffromer committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ac6dd83 View commit details
    Browse the repository at this point in the history

  3. Clean up duplicate text.

    @geoffromer
    geoffromer committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    b975085 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Restructure to focus on symbolic values

    @geoffromer
    geoffromer committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    da04766 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Restructure/simplify pattern matching semantics

    @geoffromer
    geoffromer committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b7f5e28 View commit details
    Browse the repository at this point in the history

  2. Miscellaneous cleanup.

    @geoffromer
    geoffromer committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    08c8317 View commit details
    Browse the repository at this point in the history

  3. Update Type to type

    @geoffromer
    geoffromer committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    9e8ca4d View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Add discussion of named packs

    @geoffromer
    geoffromer committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7bc0533 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Clarify boundary between syntactic and reified

    @geoffromer
    geoffromer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    f78cf5b View commit details
    Browse the repository at this point in the history

  2. Introduce "kernel"

    @geoffromer
    geoffromer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    2cb427c View commit details
    Browse the repository at this point in the history

  3. Clear up "parameter"/"argument" terminology

    @geoffromer
    geoffromer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    8d972ac View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Respond to reviewer comments

    @geoffromer
    geoffromer committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    3155e3c View commit details
    Browse the repository at this point in the history

  2. Resolve FIXMEs

    @geoffromer
    geoffromer committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    3ecbf7d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2106223 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Respond to reviewer comments. 

    Most notably, introduce the "pack index" variable in place of "representatives" (and use the term "representative" for something else)
    @geoffromer
    geoffromer committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ad7a665 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored May 1, 2023
    Configuration menu
    Copy the full SHA
    ae87a45 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Add alternatives considered

    @geoffromer
    geoffromer committed May 5, 2023
    Configuration menu
    Copy the full SHA
    15ce15c View commit details
    Browse the repository at this point in the history

  2. Add abstract and rationale

    @geoffromer
    geoffromer committed May 5, 2023
    Configuration menu
    Copy the full SHA
    0ae69fd View commit details
    Browse the repository at this point in the history

  3. Split out design details

    @geoffromer
    geoffromer committed May 5, 2023
    Configuration menu
    Copy the full SHA
    bbb1aee View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Rephrase variadic design to fit new context

    @geoffromer
    geoffromer committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ac50c98 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add alternate keyword-based syntax

    @geoffromer
    geoffromer committed May 23, 2023
    Configuration menu
    Copy the full SHA
    87018e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Richard Smith <richard@metafoo.co.uk>
    @geoffromer @zygoloid
    geoffromer and zygoloid authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    0591139 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Respond to reviewer comments

    @geoffromer
    geoffromer committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3b5a57b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Use "singular" in place of "scalar"

    @geoffromer
    geoffromer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8a0cc79 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Switch to iterative model

    @geoffromer
    geoffromer committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6808a3c View commit details
    Browse the repository at this point in the history

  2. Minimal pivot to "Model 2"

    @geoffromer
    geoffromer committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    4c546fd View commit details
    Browse the repository at this point in the history

  3. Allow each in deduced params 

    As a consequence, drop support for arrays
    @geoffromer
    geoffromer committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    622252b View commit details
    Browse the repository at this point in the history

  4. Don't require parens around each

    @geoffromer
    geoffromer committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    821223c View commit details
    Browse the repository at this point in the history

  5. Rename [:] to expand

    @geoffromer
    geoffromer committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d39bf0b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update p2240.md 

    - Also some minor tweaks to variadics.md
    @geoffromer
    geoffromer committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c22b61a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    31290a0 View commit details
    Browse the repository at this point in the history

  2. Respond to reviewer comments

    @geoffromer
    geoffromer committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e2e09de View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Add conceptual overview to variadics.md

    @geoffromer
    geoffromer committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    b00074f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Respond to reviewer commments 

    (Including comments from the 2023-08-31 open discussion)
    @geoffromer
    geoffromer committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0b3ffd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    4615603 View commit details
    Browse the repository at this point in the history

  2. Add citation

    @geoffromer
    geoffromer committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d5f18af View commit details
    Browse the repository at this point in the history

  3. Respond to reviewer comments

    @geoffromer
    geoffromer committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    349cb71 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Respond to reviewer feedback

    @geoffromer
    geoffromer committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    a7966e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Add comparison table, and update background

    @geoffromer
    geoffromer committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a358482 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Richard Smith <richard@metafoo.co.uk>
    @geoffromer @zygoloid
    geoffromer and zygoloid authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c1645e2 View commit details
    Browse the repository at this point in the history

  2. Respond to reviewer comments

    @geoffromer
    geoffromer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    14b97b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. New approach to type deduction

    @geoffromer
    geoffromer committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b16a5d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Add missing alternative-considered. 

    Also respond to some early design feedback
    @geoffromer
    geoffromer committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f4525b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Allow deducing arity from scrutinee in more cases.

    @geoffromer
    geoffromer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    4d17a2a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. WIP checkpoint before trying new notation

    @geoffromer
    geoffromer committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    00f318a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'trunk' into variadics

    @geoffromer
    geoffromer committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0711131 View commit details
    Browse the repository at this point in the history

  2. Checkpoint

    @geoffromer
    geoffromer committed May 14, 2024
    Configuration menu
    Copy the full SHA
    61a0cc1 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Add appendix

    @geoffromer
    geoffromer committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cdc9fff View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Rewrite main exposition based on appendix.

    @geoffromer
    geoffromer committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    955cb1d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Clarify and correct discussion of pattern matching

    @geoffromer
    geoffromer committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2ca3c36 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Respond to reviewer comments

    @geoffromer
    geoffromer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    20ee2e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Respond to reviewer comments

    @geoffromer
    geoffromer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6b799d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Update p2240.md to match the current design

    @geoffromer
    geoffromer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c8111cb View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5d9d2ad View commit details
    Browse the repository at this point in the history

  2. Correct suggestions

    @geoffromer
    geoffromer committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    21b6370 View commit details
    Browse the repository at this point in the history

  3. Typo fixes

    @geoffromer
    geoffromer committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6d5691e View commit details
    Browse the repository at this point in the history

  4. Respond to reviewer comments

    @geoffromer
    geoffromer committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    05e8b92 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. New discussion of library API principle

    @geoffromer
    geoffromer committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    acf1bfc View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
    @geoffromer @chandlerc @josh11b
    3 people authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9cf7e34 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
    @geoffromer @CarbonInfraBot
    geoffromer and CarbonInfraBot authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    07a8474 View commit details
    Browse the repository at this point in the history

  2. Respond to reviewer comments.

    @geoffromer
    geoffromer committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3fe5c94 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
    @geoffromer @josh11b
    geoffromer and josh11b authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6d75856 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Richard Smith <richard@metafoo.co.uk>
    @geoffromer @zygoloid
    geoffromer and zygoloid authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d00d51e View commit details
    Browse the repository at this point in the history

  3. Respond to reviewer comments

    @geoffromer
    geoffromer committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f2bce4d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Switch to guillemets

    @geoffromer
    geoffromer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6bb6b18 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Apply notation changes to p2240.md

    @geoffromer
    geoffromer committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ee3792a View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Respond to reviewer comments

    @geoffromer
    geoffromer committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9caff84 View commit details
    Browse the repository at this point in the history