Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What can be done with an incomplete interface #2347

Merged
merged 12 commits into from
Nov 9, 2022
Merged

What can be done with an incomplete interface #2347

merged 12 commits into from
Nov 9, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Oct 25, 2022 •
edited
Loading

Clarify what can and cannot be done with a incomplete interface or named constraint.

@josh11b josh11b added proposal A proposal proposal draft Proposal in draft, not ready for review labels Oct 25, 2022
@josh11b josh11b requested a review from zygoloid October 31, 2022 21:05
@josh11b josh11b marked this pull request as ready for review October 31, 2022 21:05
@github-actions github-actions bot added proposal rfc Proposal with request-for-comment sent out and removed proposal draft Proposal in draft, not ready for review labels Oct 31, 2022
zygoloid
zygoloid reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docs/design/generics/details.md Show resolved Hide resolved
josh11b and others added 2 commits November 1, 2022 10:51
@josh11b @zygoloid
Update docs/design/generics/details.md
95bab4a 
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@josh11b
Fix formatting
f161306
@chandlerc chandlerc added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Nov 9, 2022
@josh11b josh11b merged commit e29e4cf into carbon-language:trunk Nov 9, 2022
@josh11b josh11b deleted the incomplete branch November 9, 2022 16:37
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid left review comments

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
documentation An issue or proposed change to our documentation proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh11b @zygoloid @chandlerc