Rewrite authentication flow. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonmeow
commented
May 29, 2020
jonmeow
commented
- Use session tokens for:
- The 14-day expiry vs previous 1-hour
- Validate GitHub identity once per-session
- Use caching for performance
- Still some problems due to firebase function cold-start costs -- not sure I can do much about that without a lot more work (doesn't seem worth it).
- Improve logging.
- Use session tokens for: - The 14-day expiry vs previous 1-hour - Validate GitHub identity once per-session - Use caching for performance - Improve logging.
chandlerc
approved these changes
May 29, 2020
This was referenced May 11, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.