-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish toolchain and language versioning #4105
Conversation
Ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. While I have a few comments, they're mostly around the presentation rather than the rules; the only real non-cosmetic question is whether we still want the -0.
in nightly and dev versions now that it's not necessary to get them to sort before -alpha
and -beta
.
- `MAJOR.MINOR.PATCH-rc.N`: The N-th potentially viable candidate for a | ||
release. | ||
- `MAJOR.MINOR.PATCH-0.nightly.YYYY.MM.DD`: A nightly incremental | ||
development build on a particular day during development of that | ||
version. | ||
- `MAJOR.MINOR.PATCH-0.dev`: An interactive, incremental development build | ||
on a particular day by some developer during development of that | ||
version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we don't have -alpha
and -beta
here, it seems that we don't need the -0.
prefix to ensure that dev
and nightly
are ordered before rc
. Would it make sense to remove the 0.
part? (We could add it back in future if we add back alpha
/ beta
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to do this... It seems nice to have nightly
and dev
be more explicitly separate categories from rc
or anything else we have here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I don't have a strong opinion. And maybe relying on the coincidence that dev
and nightly
collate before rc
is too "clever".
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
With this our infrastructure should match the final form of proposal #4105 that established our versioning scheme.
Proposal for how Carbon version numbers work:
Carbon
milestones
versions, and standardization