Handle unknown lines in DebugInfo #4252
Conversation
|
FYI @dwblaikie |
There was a problem hiding this comment.
(not sure what the conventions are for approval - since the author has commit rights, whether you just wanted my domain-specific review, or if I should leave approval to someone with commit rights/some other authority?)
Change looks OK to me (one minor side comment/thought).
The output changes look OK/consistent with how Clang generates debug info source locations for global constructors. (the global ctor function itself has no line, but the instructions inside it do point to the relevant parts of the initializing subexpressions)
There was a problem hiding this comment.
(thought I picked the approve button, but guess got sidetracked by my own rambling considerations in the previous message)
ooh, I did pick approve, but it doesn't highlight green because of my permissions - then I didn't notice the subtle grey checkmark. Don't mind me.
Mainly, changes the default from -1 to 0 in DiagnosticLoc, still trying to keep reusing that. Nothing except for the lowered output is affected, so I think this is fine. Also, have lowering consistently call GetDiagnosticLoc. Pulls in one of the CHECKs suggested from carbon-language#4251 Co-authored-by: David Blaikie <dblaikie@gmail.com>
Mainly, changes the default from -1 to 0 in DiagnosticLoc, still trying to keep reusing that. Nothing except for the lowered output is affected, so I think this is fine. Also, have lowering consistently call GetDiagnosticLoc. Pulls in one of the CHECKs suggested from carbon-language#4251 Co-authored-by: David Blaikie <dblaikie@gmail.com>
Mainly, changes the default from -1 to 0 in DiagnosticLoc, still trying to keep reusing that. Nothing except for the lowered output is affected, so I think this is fine.
Also, have lowering consistently call GetDiagnosticLoc.
Pulls in one of the CHECKs suggested from #4251
Co-authored-by: David Blaikie dblaikie@gmail.com