Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower global variables as global definitions, not global declarations. #4674

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Lower global variables as global definitions, not global declarations. #4674

merged 1 commit into from
Dec 12, 2024

Conversation

zygoloid
Copy link
Contributor

@zygoloid zygoloid commented Dec 12, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot requested a review from jonmeow December 12, 2024 22:18
@zygoloid zygoloid mentioned this pull request Dec 12, 2024
Merged
jonmeow
jonmeow approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonmeow jonmeow enabled auto-merge December 12, 2024 22:19
@jonmeow jonmeow added this pull request to the merge queue Dec 12, 2024
Merged via the queue into carbon-language:trunk with commit 3e0fdd0 Dec 12, 2024
10 checks passed
bricknerb pushed a commit to bricknerb/carbon-lang that referenced this pull request Dec 16, 2024
@zygoloid @bricknerb
Lower global variables as global definitions, not global declarations. (
9b2c5cc 
carbon-language#4674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zygoloid @jonmeow