Stop allowing impl redeclarations to differ syntactically in where clause
#4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
approved these changes
Jan 27, 2025
toolchain/check/handle_impl.cpp
Outdated
| last_param_iter); | ||
| } while (where_operands_to_skip > 0); | ||
| } | ||
| Parse::NodeId last_param_node_id(end_of_decl_node_id.index - 1); |
There was a problem hiding this comment.
Would it make sense to keep treating NodeId::index as opaque, keeping the PostorderIterator use? As a reminder, #4762 (comment)
There was a problem hiding this comment.
Switched back to using PostorderIterator.
toolchain/check/testdata/impl/no_prelude/impl_where_redecl.carbon
Outdated
Show resolved
Hide resolved
Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
josh11b
commented
Jan 28, 2025
I fixed the bad merge, tests now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the lastest thinking on #4672 , require a full syntactic match for impl redeclaration, instead of excluding the
whererestriction. This means no updates to the impl witness on redeclaration, and no diagnostics that those updates are consistent.Not included in this PR, but will need to be done in the future:
check/impl.cppthat are now always called together.Also add some test coverage of
whereparsing I developed in PR I've now abandoned because of this new simplification of the impl redeclaration semantics.