Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator precedence #555

Merged
merged 7 commits into from
Jun 25, 2021
Merged

Operator precedence #555

merged 7 commits into from
Jun 25, 2021

Conversation

zygoloid
Copy link
Contributor

@zygoloid zygoloid commented May 27, 2021

Proposal to use a partial precedence ordering for operator precedence, rather than a total ordering as found in most languages. Factored out of #168.

@zygoloid zygoloid added the proposal A proposal label May 27, 2021
@zygoloid zygoloid requested a review from a team May 27, 2021 00:56
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label May 27, 2021
@zygoloid zygoloid marked this pull request as ready for review June 24, 2021 01:07
@zygoloid zygoloid requested a review from a team as a code owner June 24, 2021 01:07
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Jun 24, 2021
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just making suggestions where I think it may help readability

proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed review feedback.

proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
proposals/p0555.md Outdated Show resolved Hide resolved
@jonmeow
Copy link
Contributor

jonmeow commented Jun 24, 2021

Thanks for the changes!

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this proposal! I've flagged one super minor wording thing that I think we should sort out and apply, but that's the only change I really see worth pursuing here.

proposals/p0555.md Outdated Show resolved Hide resolved
@chandlerc chandlerc self-assigned this Jun 25, 2021
professional Carbon developers -> developers who regularly use Carbon
programmer -> developer
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@zygoloid zygoloid merged commit 84a7990 into carbon-language:trunk Jun 25, 2021
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Jun 25, 2021
@jonmeow jonmeow mentioned this pull request Feb 9, 2022
jonmeow added a commit that referenced this pull request Feb 18, 2022
@zygoloid zygoloid deleted the proposal-operator-precedence branch March 11, 2022 01:00
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants