Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Int parsing to i32 for #543 #700

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Move Int parsing to i32 for #543 #700

merged 4 commits into from
Aug 5, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 3, 2021 •
edited
Loading

Note this doesn't support other sizes or types, it just errors on them.

@jonmeow jonmeow requested a review from geoffromer August 3, 2021 20:33
@jonmeow jonmeow requested a review from a team as a code owner August 3, 2021 20:33
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Aug 3, 2021
geoffromer
geoffromer approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@geoffromer geoffromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full disclosure: I didn't even look at most of the testdata changes, because I assume they're purely mechanical, and there's a lot of them. Let me know if you'd prefer that I review them.

executable_semantics/syntax/parser.ypp Outdated Show resolved Hide resolved
jonmeow and others added 3 commits August 4, 2021 11:41
@jonmeow jonmeow merged commit 5947ba1 into carbon-language:trunk Aug 5, 2021
@jonmeow jonmeow deleted the new-ints branch August 5, 2021 16:34
@jonmeow jonmeow mentioned this pull request Aug 19, 2021
Closed
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow @geoffromer
Move Int parsing to i32 for #543 (#700)
2620ba0 
Note this doesn't support other sizes or types, it just errors on them.

Co-authored-by: Geoff Romer <gromer@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer geoffromer approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @geoffromer