Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty tuple constructor #708

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Add empty tuple constructor #708

merged 3 commits into from
Aug 6, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 5, 2021 •
edited
Loading

I went towards Empty() because I was thinking, why make multiple instances?

@jonmeow jonmeow requested a review from geoffromer August 5, 2021 16:27
@jonmeow jonmeow requested a review from a team as a code owner August 5, 2021 16:27
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Aug 5, 2021
@geoffromer
Copy link
Contributor

I went towards Empty() because I was thinking, why make multiple instances?

I can see arguments both ways, e.g. we might want to have a distinct C++ object for each occurrence of a Carbon value, so we can associate per-usage metadata with it. But we can always change this when/if we decide to do that.

@jonmeow jonmeow merged commit 127fa96 into carbon-language:trunk Aug 6, 2021
@jonmeow jonmeow deleted the tuple-unit branch August 6, 2021 17:06
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow
Add TupleValue::Empty for the common empty tuple case (#708)
5749413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer geoffromer approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @geoffromer