Support external impl in class and adapter scopes.
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
reviewed
Oct 25, 2021
There was a problem hiding this comment.
I'm quite happy with this, but curious what the other leads think about whether this needs a proposal? To me, it is below my bar for that, but only barely so really open to what other leads think here. @zygoloid @KateGregory
zygoloid
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
I don't think there's anything for a proposal to say here; we prepared for this syntax so there aren't really any other alternatives considered, and the background and problem statement are contained in the design doc change. On that basis, I don't see a need for a proposal, and I'm happy with this change.
josh11b
added a commit
that referenced
this pull request
Dec 7, 2021
Includes a variety of changes: Int -> i32 this -> me expand terminology doc and add links to it fix text to reflect inline external impl introduced in Support external impl in class and adapter scopes. #905 no longer have plans for runtime type parameters style updates like removing parentheticals and "we" observe is a "declaration" not a "statement", since it can appear outside function bodies many individual updates, clean-ups, and fixes Co-authored-by: Richard Smith <richard@metafoo.co.uk>
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
Includes a variety of changes: Int -> i32 this -> me expand terminology doc and add links to it fix text to reflect inline external impl introduced in Support external impl in class and adapter scopes. #905 no longer have plans for runtime type parameters style updates like removing parentheticals and "we" observe is a "declaration" not a "statement", since it can appear outside function bodies many individual updates, clean-ups, and fixes Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.