Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of _windowsDirnamePattern #52

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Correction of _windowsDirnamePattern #52

merged 2 commits into from
Dec 18, 2019

Conversation

CMAraujo87
Copy link
Contributor

Fixes #41

When trying to convert to pdf file, I got an error telling me that LibreOffice is not installed.

Scenario:
OS: Windows 7 SP1 (x64)
LibreOffice Version: 6.2.5.2 (x64)
soffice.exe Path: 'C:/Program Files/LibreOffice/program/soffice.exe'

The current filter cannot find this path: (Line 497 of file "converter.js")
var _windowsDirnamePattern = /^LibreOffice \d+(?:\.\d+)?$/i;

I could correct it locally by changing it to:
var _windowsDirnamePattern = /^LibreOffice( \d+(?:\.\d+)?)?$/i;

Copy link

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a desperately needed fix for new Windows users leveraging carbone. Aside from the minor regex change recommendation I think this looks great and should be considered as soon as possible.

lib/converter.js Outdated Show resolved Hide resolved
Accepts "LibreOffice", "LibreOffice 6.3", AND "LibreOffice 6.3.4.2"
@dgrelaud dgrelaud merged commit 6301e44 into carboneio:master Dec 18, 2019
@dgrelaud
Copy link
Member

Thank you ;).

I will a publish a new version at the end of december (with other new feature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibreOffice not fund on windows
4 participants