Correction of _windowsDirnamePattern #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
When trying to convert to pdf file, I got an error telling me that LibreOffice is not installed.
Scenario:
OS: Windows 7 SP1 (x64)
LibreOffice Version: 6.2.5.2 (x64)
soffice.exe Path: 'C:/Program Files/LibreOffice/program/soffice.exe'
The current filter cannot find this path: (Line 497 of file "converter.js")
var _windowsDirnamePattern = /^LibreOffice \d+(?:\.\d+)?$/i;
I could correct it locally by changing it to:
var _windowsDirnamePattern = /^LibreOffice( \d+(?:\.\d+)?)?$/i;