Move size check logic into shared helper

carbonplan · Jan 15, 2025 · 1383be3 · 1383be3
1 parent f93f559
commit 1383be3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/components/utils/data.js b/components/utils/data.js
@@ -96,6 +96,10 @@ export const toKeyArray = (chunkKey, { chunk_separator }) => {
   return chunkKey.split(chunk_separator).map(Number)
 }
 
+const isArrayOverSizeLimit = (dimensions) => {
+  return dimensions.reduce((product, d) => product * d, 1) >= MAX_ARRAY_LENGTH
+}
+
 const getChunkShapeOverride = (chunkShape, shape, dimensions, axes) => {
   if (chunkShape.length === 1) {
     return null
@@ -104,8 +108,7 @@ const getChunkShapeOverride = (chunkShape, shape, dimensions, axes) => {
   const fullSpace =
     dimensions
       .filter((d) => [axes?.X, axes?.Y].includes(d))
-      .every((d) => d <= 360) &&
-    chunkShape.reduce((product, d) => product * d, 1) < MAX_ARRAY_LENGTH
+      .every((d) => d <= 360) && !isArrayOverSizeLimit(chunkShape)
 
   return dimensions.map((d, i) => {
     if ([axes?.X, axes?.Y].includes(d)) {
@@ -353,7 +356,7 @@ export const getVariableInfo = async (
         if (
           isSpatialDimension(dimensions[i]) ||
           !arr ||
-          arr.shape > MAX_ARRAY_LENGTH
+          isArrayOverSizeLimit(arr.shape)
         ) {
           return null
         } else {