Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Added support to new runtime permissions model of Android M #28

Closed
wants to merge 1 commit into from

Conversation

josemedaglia
Copy link

No description provided.

@jaypatel512
Copy link
Contributor

What are your thoughts on somehow re-using the runtime permissions code in card.io-Android-Source native implementation ?

@benjefferies
Copy link

I am getting issues on android 6 where it doesn't open the camera. Is this the behaviour you were seeing?

@josemedaglia
Copy link
Author

Hi @jaypatel512, it's interesting Card.io already supported in some way the new Android permission model, I've just tested and it is working when you actually call the scan method. The problem I was seeing is that they didn't implement request for permissions for canReadCardWithCamera method (used by canScan method of the Cordova plugin).

It it's implemented in Card.io then there is no need to add it to the plugin, I'm going to report the issue to the other repo.

@braebot
Copy link
Member

braebot commented May 17, 2016

It's already reported in card-io/card.io-Android-SDK#136.

@josemedaglia
Copy link
Author

Yeah I've just noticed!
I'm going to close this pull request then and wait for the issue to be resolved in Card.io.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants