Staking key chain for HD wallets #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Dec 1, 2020
StakingKey/README.md
Outdated
|
|
||
| We RECOMMEND wallets only use `address_index=0` for compatibility with existing software. This also avoids the need for staking key discovery. | ||
|
|
||
| Wallets that use multiple staking keys are REQUIRED to use sequential indexing with no gaps. This is to make detection of mangle addresses (addresses where the payment key belongs to the user, but the staking key doesn't) easier. |
There was a problem hiding this comment.
*the detection of mangle addresses possible (
I imagine.
KtorZ
approved these changes
Dec 1, 2020
|
can we change the structure to match the new repo format (so Github can display appropriately)? |
crptmppt
suggested changes
Dec 9, 2020
|
|
||
| ## Abstract | ||
|
|
||
| Starting with the Shelley hardfork, Cardano makes use of both the *UTXO model* and the *account model*. To support both transaction models from the same master key, we allocate a new chain for [CIP1852](../CIP1852) |
There was a problem hiding this comment.
need to change link to ../CIP-1852
|
|
||
| ## Specification | ||
|
|
||
| Recall that [CIP1852](../CIP1852) specifies the following derivation path |
There was a problem hiding this comment.
need to change link to ../CIP-1852
crptmppt
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per our discussion during the CIP call, I split up #33 into two CIPs. This CIP contains the description of
chain=2whereas CIP1852 now outlines the derivation strategy and acts as a registry of chain types.