Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0084? | Ledger evolution (meta) #456
CIP-0084? | Ledger evolution (meta) #456
Changes from all commits
d25ef75
c2cc30d
06fc0ab
ec32230
c532046
ec6e0bb
7dd1026
8dc3fde
3bb5531
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "Specification" would benefit from a short section about what it takes for a ledger CIP to become active. Are you expecting people to submit PRs to the ledger, or would you rather avoid people doing so (and have only the core maintainers do the work that's agreed on CIPs)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something in the middle, I think. This involves perhaps a big topic that we should discuss.
Features do not get implemented in isolation in the ledger. We collect up a bunch of features, see how they interact, design a specification for a new ledger era, and then implement the era. I actually wrote up an earlier draft of this CIP that was much different than what I've submitted, where "ledger era" was its own ledger sub-type. In the end, I talked myself out of this since it could be argued that this is more of the release process. The ledger team would of course love help with PRs, but it would need to match our existing workflow, which is to build out the code once the era is settled. I'm not sure how the bundling should be involved in the CIP process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could probably use some guidance from the CIP committee as to how to organize this. These are the stages in my mind:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think ledger events should pretty clearly be "out". They don't affect the operation of the Cardano network. A competing implementation could omit them and be perfectly correct.