-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0098? | Distributed Artifact Token Metadata #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wout, thanks for this interesting proposal!
Please see below the small editorial type comments mainly about the structure of the proposal. And can you rename the directory from CIP-0098 to something like CIP-XXXX or CIP-????.
I do have one larger question:
- How would this proposal be versioned? since you mention this could be extended over time.
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Thanks for going through it, and sorry for the many individual commits. 😊️
I hoped to discuss this here because I'm unsure how to approach it. Argument directives are a part of the CIP that should be open for additions. If someone comes up with something useful, we should be able to add it. One idea I had was to use two-part versioning (e.g. The other idea was to extract argument directives from the standard and maintain the list somewhere else. The content of the directives is not important to the standard, only their function is. But this approach would create fragmentation, which I don't like. So, I'd like to redirect the question back here. EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wout FYI we are introducing this proposal at the CIP editors' meeting today (4PM UTC). I've seen you on Discord there; let me know if any other advocates of this proposal might be there & we can send them a Discord invite.
My preliminary review is:
- it seems to solve the problem that this deprecated proposal (CIP-0048? | NFT metadata references and payloads #249 (comment)) was trying to solve, without the features that led to its deprecation. Therefore it could be instructive to readers to mention in the Rationale why this earlier considered alternative (adding an "external metadata" tag to existing metadata structures) was unpopular.
- That proposal was deprecated in favour of the draft CIP-0088 (CIP-0088? | Token Policy Registration #467 (comment)), so could that other CIP approach be compared in the Rationale here as well?
You're not obligated to produce a CPS-like review of the whole problem, but to encourage people to adopt this as a standard it would be proactive to position it favourably compared to other potential solutions.
@wout I'm about to assign a number to this although the discussion at the meeting today was looking for more confirmation that this is used outside your own organisation. Until that's established we have to remove the word Other editors were also interested in seeing a comparative explanation of your approach as requested in #530 (review). |
p.s. update to title requested in https://github.com/venster-io/CIPs/pull/1. |
@wout I'm marking this This PR came up in a review out outstanding proposals at the CIP Editors' meeting today and we noted some potential difficulties in passing review resulting from both these conditions:
Please respond about this reservation & what you might be prepared to do about it. We still don't have all editors expressing opinions about this, but it might not be possible to approve this CIP if it's only documenting a single implementation. If we don't have an answer with the usual review time frame we might have to eventually deprecate or close this. |
@rphair Sorry for the delayed reply. I'm going through some personal stuff and don't have the headspace for it at the moment. |
Thanks for the update @wout ... feel free to open this again if & when you want to pursue the proposal further. |
* promote CIP-0102 and fix some white space there * set CPS-0007 title to its official title in top README * author abandoned #530 * added implementors Co-authored-by: Sam Delaney <sam@thedelaneys.net> * added extension boilerplate Co-authored-by: Sam Delaney <sam@thedelaneys.net> --------- Co-authored-by: Sam Delaney <sam@thedelaneys.net>
…foundation#606) * promote CIP-0102 and fix some white space there * set CPS-0007 title to its official title in top README * author abandoned cardano-foundation#530 * added implementors Co-authored-by: Sam Delaney <sam@thedelaneys.net> * added extension boilerplate Co-authored-by: Sam Delaney <sam@thedelaneys.net> --------- Co-authored-by: Sam Delaney <sam@thedelaneys.net>
In the past one and a half years, I've released three on-chain generative token collections on Cardano, and I developed this standard out of necessity.
Introductory information is available here:
https://docs.venster.art/dats.html
And a slightly more detailed version of this CIP is available here:
https://docs.venster.art/dat-metadata-standard.html
The content of the CIP on our documentation page is the same as in this PR but with a bit more inline information.
Rendered Proposal in Branch