Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPS-0010? | Wallet Connectors #619

Merged
merged 41 commits into from
Feb 6, 2024
Merged

CPS-0010? | Wallet Connectors #619

merged 41 commits into from
Feb 6, 2024
+356 −0

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Nov 16, 2023 •
edited
Loading

This problem statement is concerned with the issues surrounding Cardano's current and future wallet connectors.
These interfaces are difficult to define and historically have been even harder to iterate upon.
We wish to provide a comprehensive catalog of the current offerings; and their drawbacks to be able to make suggestions on future standards.

I thought it important that such a problem statement is open for much community input, so have started this as a draft PR.

Todo

  • Hold first workshop
  • Hold second workshop
  • Enrich context subsection
  • Add to open questions section

Open Questions

  • Can wallet connector standards define when wallets should ask users for permission?
    • No, this is the responsibility of the wallet, although a separate CIP could define general best practices.
  • Where does the role of transaction building sit?
    • Will push this question to a subsequent CIP.

📰 Rendered Problem Statement (on fork)

@Ryun1 Ryun1 added the Category: Wallets Proposals belonging to the 'Wallets' category. label Nov 16, 2023
@Ryun1 Ryun1 changed the title CIP-???? | Cardano Wallet Connectors [Draft] CPS-???? | Cardano Wallet Connectors [Draft] Nov 16, 2023
@rphair
Copy link
Collaborator

rphair commented Nov 17, 2023 •
edited
Loading

@Ryun1 looks promising so far... already as good an inventory of the issue as I could imagine. I'll happily leave it to you when to mark Ready for review and/or kick it off in the CIP meeting agenda.

This was referenced Nov 17, 2023
Draft
Open
@rphair rphair mentioned this pull request Nov 27, 2023
Closed
@Ryun1 @rphair
Update cps-wallet-connector/README.md
44ac6c4 
Co-authored-by: Robert Phair <rphair@cosd.com>
@Ryun1 Ryun1 changed the title CPS-???? | Cardano Wallet Connectors [Draft] CPS-???? | Cardano Wallet Connectors Nov 28, 2023
@Ryun1 Ryun1 marked this pull request as ready for review November 28, 2023 14:27
klntsky
klntsky reviewed Nov 28, 2023
View reviewed changes
cps-wallet-connector/README.md Outdated Show resolved Hide resolved
cps-wallet-connector/README.md Outdated Show resolved Hide resolved
cps-wallet-connector/README.md Outdated Show resolved Hide resolved
rphair
rphair reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ryun1 one thing that helps keep the lists of CIP and CPS titles concise is not using the word Cardano in the document title when it's already in the CIP/CPS acronym...

cps-wallet-connector/README.md Outdated Show resolved Hide resolved
@rphair rphair changed the title CPS-???? | Cardano Wallet Connectors CPS-0010? | Wallet Connectors Nov 28, 2023
@rphair rphair mentioned this pull request Nov 28, 2023
Merged
rphair
rphair reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you know @Ryun1 enthusiastically approved as candidate in today's CIP meeting...

cps-wallet-connector/README.md Outdated Show resolved Hide resolved
Ryun1 and others added 2 commits November 29, 2023 08:31
@Ryun1 @rphair
Update cps-wallet-connector/README.md
a1f03fb 
Co-authored-by: Robert Phair <rphair@cosd.com>
@Ryun1 @rphair
Update cps-wallet-connector/README.md
9d961b6 
Co-authored-by: Robert Phair <rphair@cosd.com>
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
@Ryun1 @klntsky
Update CPS-0010/README.md
c80da90 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
Ryun1 and others added 5 commits January 5, 2024 13:34
@Ryun1 @klntsky
Update CPS-0010/README.md
0f71bd6 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1 @klntsky
Update CPS-0010/README.md
bfd2c1f 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1 @klntsky
Update CPS-0010/README.md
a5c33ac 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1 @klntsky
Update CPS-0010/README.md
f5fbe5e 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1 @klntsky
Update CPS-0010/README.md
78c73e7 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
klntsky
klntsky reviewed Jan 5, 2024
View reviewed changes
CPS-0010/README.md Outdated Show resolved Hide resolved
Ryun1 and others added 6 commits January 5, 2024 13:55
@Ryun1
small notes
7e05b29
@Ryun1 @klntsky
Update CPS-0010/README.md
763892d 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1 @klntsky
Update CPS-0010/README.md
d0ee758 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1 @klntsky
Update CPS-0010/README.md
f3a141a 
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@Ryun1
add acknowledgements and notes from workshop 3
5ba6a01
@Ryun1
small tidy up
f462c0e
rphair
rphair approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal looks mature from extended discussion, feedback & update based on repeated reviews. From my point of view nothing could make it any better except 1 more workshop, which @Ryun1 says is coming soon and perhaps some more feedback will come in then. In anticipation of 1 more round of refinement I am clearing the way for this to be merged afterward.

@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label Jan 23, 2024
Crypto2099
Crypto2099 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has had plenty of time for community feedback and looks to be in a quite complete format for now. I'm sure that future questions and issues may arise as we begin writing CIPs to address this problem, but we can add those in the future.

@Ryun1 Ryun1 merged commit 56936be into cardano-foundation:master Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Closed
Ryun1 added a commit to Ryun1/CIPs that referenced this pull request Feb 20, 2024
@Ryun1 @rphair @klntsky
CPS-0010? | Wallet Connectors (cardano-foundation#619)
54e990e 
* Init cps wallet connectors

* planned conext section

* edits

* Add in achknowledgements section from first workshop

* Update cps-wallet-connector/README.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* add notes from first workshop

* Update cps-wallet-connector/README.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Expand definitions of three wallet types

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* rename folder to match CPS-10 naming

* grammar fixes

* detials and responding to comments

* UI is not the concern of the connector

* Add myself to the list of authors

* Fix duplication

* Expand open questions

* grammar + small notes from second workshop

* Apply suggestions from code review

Co-authored-by: Robert Phair <rphair@cosd.com>

* fleshing out missing sections and reorganization

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* small notes

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* add acknowledgements and notes from workshop 3

* small tidy up

* fixed discussion link

---------

Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Vladimir Kalnitsky <vladimir@mlabs.city>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Ryun1 added a commit to Ryun1/CIPs that referenced this pull request Mar 6, 2024
@Ryun1 @rphair @klntsky
CPS-0010? | Wallet Connectors (cardano-foundation#619)
cbf85b1 
* Init cps wallet connectors

* planned conext section

* edits

* Add in achknowledgements section from first workshop

* Update cps-wallet-connector/README.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* add notes from first workshop

* Update cps-wallet-connector/README.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Expand definitions of three wallet types

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update cps-wallet-connector/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* rename folder to match CPS-10 naming

* grammar fixes

* detials and responding to comments

* UI is not the concern of the connector

* Add myself to the list of authors

* Fix duplication

* Expand open questions

* grammar + small notes from second workshop

* Apply suggestions from code review

Co-authored-by: Robert Phair <rphair@cosd.com>

* fleshing out missing sections and reorganization

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* small notes

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* Update CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>

* add acknowledgements and notes from workshop 3

* small tidy up

* fixed discussion link

---------

Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Vladimir Kalnitsky <vladimir@mlabs.city>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klntsky klntsky klntsky left review comments

@Crypto2099 Crypto2099 Crypto2099 approved these changes

@rphair rphair rphair approved these changes

Assignees
No one assigned
Labels
Category: Wallets Proposals belonging to the 'Wallets' category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ryun1 @rphair @klntsky @Crypto2099