Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e tests against cached wallet db #3171

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Mar 15, 2022

  • Adjusted wallet creation and clean up to only deal with wallets used in the test
  • Added explicit target wallets to be used in tests next to fixture wallets
  • Create target and fixture wallets only if they don't already exist
  • Updated workflows to use wallet db cache
  • Testing if it works... ✔️

Comments

Issue Number

ADP-1513

@piotr-iohk piotr-iohk self-assigned this Mar 15, 2022
@piotr-iohk piotr-iohk force-pushed the piotr/adp-1513/e2e-tests-from-cached-wallet-db branch from 6477159 to a42f582 Compare March 15, 2022 14:16
@piotr-iohk piotr-iohk changed the title E2e tests from cached wallet db E2e tests against cached wallet db Mar 15, 2022
:icarus => mnemonic_sentence(15),
:byron => mnemonic_sentence(12) }
fixture_wallets = { :linux => {
:fixture => { :shelley => mnemonic_sentence(24),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if :fixture and "target could not be reused. They are repeated for :linux, :macos and :windows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that :fixture are wallets on testnet that hold some ADA and assets. During the tests there are some transactions made from :fixture to :target. At the end of the suite all funds are migrated back from :target to :fixture.

Before this change both fixture and target wallets were restored from genesis and target wallets were always different wallets (from randomly generated mnemonics). Now both :fixture and :target are explicitly created and thanks to this we can use cached wallet-db in tests.

Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk piotr-iohk force-pushed the piotr/adp-1512/e2e-tests-against-pr branch from de203f6 to 3f15378 Compare March 16, 2022 13:30
Base automatically changed from piotr/adp-1512/e2e-tests-against-pr to master March 16, 2022 14:09
@piotr-iohk piotr-iohk force-pushed the piotr/adp-1513/e2e-tests-from-cached-wallet-db branch from a42f582 to b51b140 Compare March 16, 2022 14:18
@piotr-iohk piotr-iohk merged commit 3e59eb3 into master Mar 16, 2022
@piotr-iohk piotr-iohk deleted the piotr/adp-1513/e2e-tests-from-cached-wallet-db branch March 16, 2022 15:04
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 16, 2022
@piotr-iohk piotr-iohk mentioned this pull request Mar 17, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants