-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e tests against cached wallet db #3171
E2e tests against cached wallet db #3171
Conversation
6477159
to
a42f582
Compare
:icarus => mnemonic_sentence(15), | ||
:byron => mnemonic_sentence(12) } | ||
fixture_wallets = { :linux => { | ||
:fixture => { :shelley => mnemonic_sentence(24), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if :fixture and "target could not be reused. They are repeated for :linux, :macos and :windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that :fixture are wallets on testnet that hold some ADA and assets. During the tests there are some transactions made from :fixture to :target. At the end of the suite all funds are migrated back from :target to :fixture.
Before this change both fixture and target wallets were restored from genesis and target wallets were always different wallets (from randomly generated mnemonics). Now both :fixture and :target are explicitly created and thanks to this we can use cached wallet-db in tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
de203f6
to
3f15378
Compare
a42f582
to
b51b140
Compare
…e-tests-from-cached-wallet-db
Comments
Issue Number
ADP-1513