Generalize UTxO identifiers and addresses in coin selection Gen modules.
#3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/generalize-coin-selection-generators-shrinkers
branch
4 times, most recently
from
95c4e05 to
28dabdd
Compare
jonathanknowles
force-pushed
the
jonathanknowles/generalize-coin-selection-generators-shrinkers
branch
from
28dabdd to
37b7f4d
Compare
…coin-selection-property-tests Add property tests for conversion functions in `Wallet.CoinSelection`.
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/generalize-coin-selection-generators-shrinkers
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1523
Summary
This PR removes the dependency on
AddressandWalletUTxOfrom the following modules:Cardano.Wallet.CoinSelection.Internal.Balance.GenCardano.Wallet.Primitive.Types.UTxOIndex.GenCardano.Wallet.Primitive.Types.UTxOSelection.GenIt moves all generators and shrinkers for
WalletUTxOto a new module:Cardano.Wallet.CoinSelection.GenFuture Work
In the long run we should be able to remove module
Cardano.Wallet.CoinSelection.Gen, as the coin selection test suite will eventually use its own test types for addresses and UTxO identifiers.But for now, we use this module as a way to minimize duplication.