Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlockfrostSpec on Windows #3182

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix BlockfrostSpec on Windows #3182

merged 1 commit into from
Mar 18, 2022

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Mar 18, 2022 •
edited
Loading

  • I have used relative path to socket counting on it being correct path on all OSs.

@Unisay Unisay requested a review from Anviking March 18, 2022 11:27
@Unisay Unisay force-pushed the yura/ADP-1426/fix-blockfrost-spec branch from e57ecf7 to 4181ad7 Compare March 18, 2022 11:35
@Unisay Unisay force-pushed the yura/ADP-1426/fix-blockfrost-spec branch 2 times, most recently from 652405b to 9ebc03e Compare March 18, 2022 12:24
Anviking
Anviking approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm provided it passes!

@Unisay Unisay marked this pull request as ready for review March 18, 2022 12:48
@Unisay
Copy link
Contributor Author

Unisay commented Mar 18, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Mar 18, 2022
@iohk-bors @Unisay
Merge #3182
5891a6d 
3182: Fix BlockfrostSpec on Windows r=Unisay a=Unisay

- [x] I have used relative path to socket counting on it being correct path on all OSs.

Co-authored-by: Yuriy Lazaryev <yuriy.lazaryev@iohk.io>
@Unisay Unisay force-pushed the yura/ADP-1426/fix-blockfrost-spec branch from 9ebc03e to f1654eb Compare March 18, 2022 12:58
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 18, 2022

Canceled.

@Unisay
Copy link
Contributor Author

Unisay commented Mar 18, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Mar 18, 2022
@iohk-bors @Unisay
Merge #3182
63ee2a1 
3182: Fix BlockfrostSpec on Windows r=Unisay a=Unisay

- [x] I have used relative path to socket counting on it being correct path on all OSs.

Co-authored-by: Yuriy Lazaryev <yuriy.lazaryev@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 18, 2022 •
edited by Anviking
Loading

Build failed:

  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:2036:13:
  1) Cardano.Wallet.Shelley.Transaction.balanceTransaction, when passed unresolved inputs, may fail
       *** Gave up! Passed only 99 tests; 5 discarded tests (10% unknown txins).

#3183

@Anviking
Copy link
Member

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 18, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit f6d4db7 into master Mar 18, 2022
@iohk-bors iohk-bors bot deleted the yura/ADP-1426/fix-blockfrost-spec branch March 18, 2022 15:20
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 18, 2022
docs: Merge #3182
d952aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unisay @Anviking