-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Mode: Time Interpreter #3221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 😊 The Ouroboros.Consensus.HardFork.History.*
appears to be surprisingly pleasant to use.
Two small comments.
Unisay
force-pushed
the
yura/ADP-1505/time-interpreter
branch
2 times, most recently
from
April 8, 2022 14:51
d9ef5b8
to
b1bce85
Compare
Unisay
force-pushed
the
yura/ADP-1505/time-interpreter
branch
from
April 8, 2022 17:24
b1bce85
to
3525610
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 11, 2022
3221: Light Mode: Time Interpreter r=Unisay a=Unisay ### Issue Number ADP-1422, ADP-1505 ### Overview [Light-mode][] (Epic ADP-1422) aims to make synchronisation to the blockchain faster by trusting an off-chain source of aggregated blockchain data. [light-mode]: https://input-output-hk.github.io/cardano-wallet/design/specs/light-mode In this pull request, we implement a function `timeInterpreter` that allows wallet to convert between relative blockchain time (epochs, slots) and absolute wall-clock time. To make such conversions correct `TimeInterpreter` needs to take into account historical values for various protocol parameters as well as past hard forks. Unfortunately Blockfrost API doesn't expose required functionality. We therefore hardcode summary information about past hard forks that happened on the Mainnet. Co-authored-by: Yuriy Lazaryev <yuriy.lazaryev@iohk.io>
Build failed:
|
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1422, ADP-1505
Overview
Light-mode (Epic ADP-1422) aims to make synchronisation to the blockchain faster by trusting an off-chain source of aggregated blockchain data.
In this pull request, we implement a function
timeInterpreter
that allows wallet to convert between relative blockchain time (epochs, slots) and absolute wall-clock time. To make such conversions correctTimeInterpreter
needs to take into account historical values for various protocol parameters as well as past hard forks.Unfortunately Blockfrost API doesn't expose required functionality. We therefore hardcode summary information about past hard forks that happened on the Mainnet.