Light mode: hardcode epoch/era conversion for the Testnet #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
force-pushed
the
yura/ADP-1504/current-node-era
branch
from
d5aa0e4 to
72ee3a1
Compare
HeinrichApfelmus
approved these changes
Apr 7, 2022
Unisay
force-pushed
the
yura/ADP-1504/current-node-era
branch
from
c8b8550 to
f9acdb5
Compare
Unisay
force-pushed
the
yura/ADP-1504/current-node-era
branch
from
f9acdb5 to
46f3d24
Compare
piotr-iohk
reviewed
Apr 8, 2022
| AnyCardanoEra ByronEra -> 0 | ||
| Testnet magic -> | ||
| error $ "Epoch/Era conversion isn't provided for the Testnet " | ||
| <> show magic <> " in light mode." |
There was a problem hiding this comment.
Since with Blockfrost provider we are supporting only mainnet and public testnet (i.e. the one with protocolMagic -> 1097911063) then perhaps we shouldn't be able to start wallet against any different testnet alltogether. E.g.:
If we start wallet with:
cardano-wallet serve \
--light \
--blockfrost-token-file blockfrost.api.key \
--testnet testnet-byron-genesis.json
and testnet-byron-genesis.json contains protocolMagic different than 1097911063 the wallet should just stop with the appropriate message.
Maybe it's not in scope of this pr though
There was a problem hiding this comment.
Or maybe starting against public testnet could be simple as:
cardano-wallet serve \
--light \
--blockfrost-token-file blockfrost.api.key \
--testnet
i.e. without the byron-genesis.json, assuming it is needed only for getting the protocolMagic from.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1422, ADP-1504
Overview
Light-mode (Epic ADP-1422) aims to make synchronisation to the blockchain faster by trusting an off-chain source of aggregated blockchain data.
In this pull request, we implement a function
currentNodeErathat that determines current Era by the current epoch retrieved from the Testnet Blockfrost API.