Light mode: fetch reward account balances #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
requested changes
Apr 13, 2022
Unisay
force-pushed
the
yura/ADP-1506/reward-account-balance
branch
from
77654c5 to
a1f83f0
Compare
… it to encode reward address.
Unisay
force-pushed
the
yura/ADP-1506/reward-account-balance
branch
from
acc2649 to
abb7825
Compare
HeinrichApfelmus
approved these changes
Apr 14, 2022
| handleBlockfrostError . fmap Map.fromList $ | ||
| for (Set.toList accounts) $ \rewardAccount -> do | ||
| BF.AccountInfo {..} <- liftBlockfrost $ BF.getAccount $ | ||
| BF.mkAddress $ encodeStakeAddress @nd rewardAccount |
There was a problem hiding this comment.
👍 Looks much better. I hope that this is correct now, but there is little we can do besides a manual test and perhaps a second look that we do indeed have unit tests for deodeStakeAddress and encodeStakeAddress
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 19, 2022
3231: Light mode: fetch reward account balances r=Unisay a=Unisay ### Issue Number ADP-1422, ADP-1506 ### Overview [Light-mode][] (Epic ADP-1422) aims to make synchronisation to the blockchain faster by trusting an off-chain source of aggregated blockchain data. [light-mode]: https://input-output-hk.github.io/cardano-wallet/design/specs/light-mode In this pull request, I have implemented two functions of the `NetworkLayer` interface: - getCachedRewardAccountBalance - fetchRewardAccountBalances Co-authored-by: Yuriy Lazaryev <yuriy.lazaryev@iohk.io>
|
Build failed: Build Timed Out |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1422, ADP-1506
Overview
Light-mode (Epic ADP-1422) aims to make synchronisation to the blockchain faster by trusting an off-chain source of aggregated blockchain data.
In this pull request, I have implemented two functions of the
NetworkLayerinterface: