Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light Mode: implement getPoolLifeCycleStatus #3320

Merged
merged 6 commits into from
Jun 13, 2022
Merged

Light Mode: implement getPoolLifeCycleStatus #3320

merged 6 commits into from
Jun 13, 2022

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Jun 9, 2022 •
edited
Loading

I have implemented getPoolLifeCycleStatus function of the StakePoolLayer for the light mode.

Tested in REPL on Testnet:

Haskell λ cfg >>= \c -> _getPoolLifeCycleStatus c net pid
PoolRegistered (PoolRegistrationCertificate {poolId = PoolId {getPoolId = "]\153(+\187H@8\v\185\140\aT\152\237\EM\131\174\225\138J\t%\185\180M\147\241"}, poolOwners = [PoolOwner {getPoolOwner = "LT\247\187\226iP\239\221\250+\249\246\159\247\254\243\132G\140G*\209h\EMv\169\DC3"}], poolMargin = Percentage (7782220156096217 % 288230376151711744), poolCost = Coin 340000000, poolPledge = Coin 100000000, poolMetadata = Just (StakePoolMetadataUrl "https://git.io/JJ7wm",StakePoolMetadataHash "M\137\ENQL)b!V\148\167\DC2-\254A\188r\141>\194H\248\SO\169\162\224\212\147\ENQ}}#8")})

Issue Number

ADP-1511

@Unisay Unisay changed the title Yura/ADP-1511/monitor-stake-pools ADP-1511 Stake pool layer for the light mode Jun 9, 2022
@Unisay Unisay force-pushed the yura/ADP-1511/monitor-stake-pools branch from b565375 to 174c1f0 Compare June 10, 2022 17:11
@Unisay Unisay changed the title ADP-1511 Stake pool layer for the light mode Light Mode: implement getPoolLifeCycleStatus Jun 10, 2022
@Unisay Unisay requested a review from HeinrichApfelmus June 10, 2022 17:12
@Unisay Unisay force-pushed the yura/ADP-1511/monitor-stake-pools branch 2 times, most recently from 33bf6e8 to f396b1c Compare June 10, 2022 17:39
@Unisay Unisay marked this pull request as ready for review June 10, 2022 17:39
@Unisay Unisay force-pushed the yura/ADP-1511/monitor-stake-pools branch from f396b1c to 645593b Compare June 13, 2022 08:17
HeinrichApfelmus
HeinrichApfelmus approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😊 Small style comments. Thanks for removing the unnecessary liftIO.

lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs
@@ -1,10 +1,8 @@
{-# OPTIONS_GHC -Wno-unrecognised-pragmas #-}

{-# LANGUAGE BlockArguments #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm still not foo fond of it, as it messes up the "whitespace separates function arguments" property. 😅)

lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Show resolved Hide resolved
lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Outdated Show resolved Hide resolved
lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Outdated Show resolved Hide resolved
lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Outdated Show resolved Hide resolved
lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Outdated Show resolved Hide resolved
lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Show resolved Hide resolved
lib/shelley/src/Cardano/Wallet/Shelley/Pools.hs Outdated Show resolved Hide resolved
@Unisay Unisay force-pushed the yura/ADP-1511/monitor-stake-pools branch from 968fa7b to a61918b Compare June 13, 2022 16:20
@Unisay
Copy link
Contributor Author

Unisay commented Jun 13, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 13, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 0ff0aa8 into master Jun 13, 2022
@iohk-bors iohk-bors bot deleted the yura/ADP-1511/monitor-stake-pools branch June 13, 2022 18:53
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jun 13, 2022
docs: Merge #3320
0462305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unisay @HeinrichApfelmus