Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement txId hash using CBOR encoders #42

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Mar 8, 2019

Issue Number

Overview

  • I have added CBOR encoders for Tx
  • I have added missing CBOR decoders
  • I have sketched a few golden tests using data from BinarySpec

Comments

Re-opening #34 because I ended up merging in the wrong base >..>

@KtorZ KtorZ self-assigned this Mar 8, 2019
@KtorZ KtorZ requested a review from Anviking March 8, 2019 14:36
- Add CBOR encoders for Tx
- Add missing CBOR decoders
- Sketch a few golden tests using data from BinarySpec
@KtorZ KtorZ force-pushed the KtorZ/#20/compute-txid branch from d426351 to 9561335 Compare March 8, 2019 14:42
@KtorZ KtorZ merged commit e1d074d into master Mar 8, 2019
@KtorZ KtorZ deleted the KtorZ/#20/compute-txid branch March 8, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants