[ADP 3491] Relax policy key guard #4850
Open
+3,919
−3,109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
reviewed
Nov 20, 2024
| @@ -2650,7 +2653,7 @@ constructTransaction api knownPools poolStatus apiWalletId body = do | |||
| makeLeft $ | |||
| toTokenMapAndScript ShelleyKeyS | |||
| scriptT | |||
| (Map.singleton (Cosigner 0) policyXPub) | |||
| (Map.singleton (Cosigner 0) $ fromJust policyXPubM) | |||
There was a problem hiding this comment.
🤔 Having to resort to an approach with fromJust seems unfortunate...
There was a problem hiding this comment.
yeah, fair point. Now no partial function fixing ;-)
paweljakubas
force-pushed
the
paweljakubas/adp-3491/relax-policy-key-guard
branch
2 times, most recently
from
ea516e3 to
3d54963
Compare
|
waiting for the daedalus team to confirm if the fix works. If yes then we will undraft it. |
paweljakubas
force-pushed
the
paweljakubas/adp-3491/relax-policy-key-guard
branch
from
9971ae7 to
d443f0e
Compare
3 tasks
handle reference script situation resign from fremJust
abailly
force-pushed
the
paweljakubas/adp-3491/relax-policy-key-guard
branch
from
d443f0e to
eab1d67
Compare
|
There's a remaining issue: |
Delegate that task to callers
|
Fix #4872 |
abailly
force-pushed
the
paweljakubas/adp-3491/relax-policy-key-guard
branch
from
5b4f4de to
ca7546a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
policyXPubis needed in constructTransaction in two cases:instead of using
policyXPubwe usepolicyXPubMthrought the function and only deconstruct it when checking those two cases.ErrReadPolicyPublicKeyAbsenis used for the those two valid situations when policy xpub is missing.Comments
Issue Number
Fix #4872