Slot to Epoch, and date to slot conversion #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemo83
force-pushed
the
feat/slot-to-epoch-conversion
branch
from
3a11a73 to
7ce62e1
Compare
matiwinnetou
approved these changes
May 15, 2024
| @@ -26,4 +27,14 @@ public LocalDateTime slotToTime(long absoluteSlot) { | |||
| // for now post byron we have 1 slot = 1 second | |||
| return genesisConfig.blockTime(EraType.Shelley, absoluteSlot); | |||
| } | |||
|
|
|||
| public Long slotToEpoch(long absoluteSlot) { | |||
There was a problem hiding this comment.
Can we somehow indicate that this is partial function in Java?
https://www.pgrs.net/2015/04/23/partial-function-application-in-java-8/
like if this is byron then function doesn't work right..
What do you think?
nemo83
changed the title
matiwinnetou
reviewed
Jul 4, 2024
| @@ -0,0 +1,28 @@ | |||
| package org.cardanofoundation.conversions.exceptioni; | |||
There was a problem hiding this comment.
why is package called in Italian? exceptioni?
There was a problem hiding this comment.
it was a typo, it's eccezioni in italian, exceptioni it's just a typo
matiwinnetou
reviewed
Jul 4, 2024
src/main/java/org/cardanofoundation/conversions/converters/SlotConversions.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing slot to epoch conversion
[x] Shelley slot to epoch conversion
[x] Byron slot to epoch conversion
Implemented date to slot conversion
[x] Shelley date to slot conversion
[x] Byron date to slot conversion