Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 18 #50

Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix issue 18 #50

merged 3 commits into from
Nov 2, 2023

Conversation

Sotatek-HuyLe3a
Copy link
Collaborator

@Sotatek-HuyLe3a Sotatek-HuyLe3a commented Oct 31, 2023

#18

}
}
target {
directory = file('src/main/java/generated')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sotatek-HuyLe3a Should we keep the generated code under src/generated, so src/main is clean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep them under src/generated, I will change

}

ext {
dbUrl = 'jdbc:postgresql://localhost:5432/ledger_sync'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explore whether we can use a Postgres testcontainer for this task. Since this is an ad hoc task, it will not be part of CI. Therefore, we will not have any resource-related issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sotatek-HuyLe3a If it's possible, let's create another issue and implement that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, generating code is not in the build process. I will try adding some config to use postgresql testcontainer

@Sotatek-HuyLe3a Sotatek-HuyLe3a merged commit 5575b05 into main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants