-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 18 #50
fix issue 18 #50
Conversation
e9645db
to
441497e
Compare
application/build.gradle
Outdated
} | ||
} | ||
target { | ||
directory = file('src/main/java/generated') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sotatek-HuyLe3a Should we keep the generated code under src/generated, so src/main is clean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep them under src/generated, I will change
} | ||
|
||
ext { | ||
dbUrl = 'jdbc:postgresql://localhost:5432/ledger_sync' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should explore whether we can use a Postgres testcontainer for this task. Since this is an ad hoc task, it will not be part of CI. Therefore, we will not have any resource-related issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sotatek-HuyLe3a If it's possible, let's create another issue and implement that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, generating code is not in the build process. I will try adding some config to use postgresql testcontainer
#18