Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Datum/Datum hash initialization #76

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Incorrect Datum/Datum hash initialization #76

merged 2 commits into from
Nov 17, 2023

Conversation

satran004
Copy link
Member

#75

  • Use Yaci's Datum.from() to initialize Datum object from cbor to populate hash correctly
  • Fixed tests

@Sotatek-HuyLe3a
Copy link
Collaborator

I understand your changes, Thanks @satran004

@Sotatek-HuyLe3a Sotatek-HuyLe3a merged commit 61071e1 into develop Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sotatek-HuyLe3a Sotatek-HuyLe3a Sotatek-HuyLe3a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satran004 @Sotatek-HuyLe3a