feat: Adding user and access management to the backend #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em when the requirements are settled
M4rc0Russ0
approved these changes
Dec 13, 2024
| @@ -5,6 +5,8 @@ dependencies { | |||
| implementation("org.springframework.modulith:spring-modulith-api") | |||
| implementation("org.springframework.modulith:spring-modulith-events-api") | |||
|
|
|||
| implementation("org.springframework.boot:spring-boot-starter-security:3.2.4") | |||
There was a problem hiding this comment.
Perhaps specifying version is not even needed as the one from spring boot will be taken automatically?
cfuisat
reviewed
Dec 19, 2024
| @@ -19,6 +25,11 @@ public class SpringWebConfig { | |||
| @Value("${lob.cors.allowed.origins:http://localhost:3000}") | |||
There was a problem hiding this comment.
@Kammerlo is this url suppose to be dev url? 'https://dev.cf-lob.metadata.dev.cf-deployments.org' currently endpoints with authorization not working. trying to see we missed anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things are still ToDo: