Improve integrate cardano guides #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve maintainability through smaller listings * fix markdown warnings * refactor csharp example
* refactor csharp code
katomm
approved these changes
Jul 22, 2021
rdlrt
approved these changes
Jul 23, 2021
Mercurial
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored some
csharpcode in the listings and fixed some markdown warnings.72d98f1 fixes some maintainability issues within the "cli" guide, by reducing the listing size. This should also happen for other guides but I haven't had time...
refering to the commit above,
docs/integrate-cardano/listening-for-payments-wallet.mdneeds some more work in the code section to become a true "guide" but I managed to achieve all the things talked about in the article and as an overview of what is possible with the wallet it's "good enough".and some typos