Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pooldata API to builder tools #364

Merged
merged 1 commit into from
Oct 28, 2021
Merged

added pooldata API to builder tools #364

merged 1 commit into from
Oct 28, 2021

Conversation

mik1893
Copy link
Contributor

@mik1893 mik1893 commented Oct 16, 2021

Builder Tools addition

  • Name: Pooldata.live API
  • Description: The Pooldata.live public API allows SPOs to access several operational metrics, allowing to augment Grafana monitoring capabilities
  • Link: https://api.pooldata.live
  • Source: -
  • Tags:
    • operatortool
    • api

@mik1893
Copy link
Contributor Author

mik1893 commented Oct 16, 2021

@katomm sorry had to recreate the pull request... for some reason it didn't like the commit squashing.

@katomm katomm added the builder tool Indicates a PR/issue on a builder tool label Oct 19, 2021
@katomm
Copy link
Member

katomm commented Oct 19, 2021

Thank you @mik1893, any idea why the image is not shown on the deploy preview: https://deploy-preview-364--staging-dev-portal.netlify.app/tools?tags=operatortool (I didn't check the binary, could it be broken?)

katomm
katomm requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image seems not to work. (please see above comment)

@mik1893
Copy link
Contributor Author

mik1893 commented Oct 22, 2021

image
It seems to be working for me when i click on your link. Do you want a different image with logo etc? I just put an image of the grafana metrics coming from the API :)

@mik1893 mik1893 requested a review from katomm October 23, 2021 16:43
katomm
katomm approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@katomm katomm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image seems to work now.

@katomm katomm merged commit 9d65744 into cardano-foundation:staging Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katomm katomm katomm approved these changes

Assignees
No one assigned
Labels
builder tool Indicates a PR/issue on a builder tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mik1893 @katomm @os-mik