Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docusaurus to 2.0.1 #718

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

katomm
Copy link
Member

@katomm katomm commented Aug 1, 2022

No description provided.

@rphair
Copy link
Collaborator

rphair commented Aug 2, 2022

this sounds great @katomm, looking forward to testing 😎 ... but why was this checked in with yarn.lock rather than modifying the relevant lines in package.json?

I know you might have your reasons & it's no problem for me... just need to know how to test accordingly (I thought we weren't checking in yarn.lock as per #665 (review)).

Just need to be sure of this because I also want to test relative to the package configuration issues observed in #691 & would like to see if the dependencies are built with yarn 3.x as they were with 1.x now that Docusaurus is out of beta.

@rphair rphair requested review from fill-the-fill and rdlrt August 2, 2022 02:52
@katomm katomm marked this pull request as draft August 2, 2022 08:49
@katomm
Copy link
Member Author

katomm commented Aug 2, 2022

why was this checked in with yarn.lock rather than modifying the relevant lines in package.json?

My apologies.

@katomm
Copy link
Member Author

katomm commented Aug 2, 2022

Okay I fixed it, @rphair. Thanks. yarn.lock should be handled only by the local yarn installation. (not sure if it makes sense to put it in git ignore, I guess not so we need to be careful on that)

@katomm katomm marked this pull request as ready for review August 2, 2022 08:57
Copy link
Collaborator

@gufmar gufmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rdlrt rdlrt merged commit fdd64fb into cardano-foundation:staging Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants