Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check elements are distinct in simple lottery. #111

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Check elements are distinct in simple lottery. #111

merged 4 commits into from
Jan 8, 2025

Conversation

tolikzinovyev
Copy link
Member

@tolikzinovyev tolikzinovyev commented Dec 16, 2024 •
edited
Loading

Content

Found another issue with the simple lottery. We need to check that elements in the proof are distinct. I guess the simple lottery is not so simple. :)

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)

@tolikzinovyev tolikzinovyev self-assigned this Dec 16, 2024
rrtoledo
rrtoledo requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add another check in the prover

src/simple_lottery/algorithm.rs Outdated Show resolved Hide resolved
@tolikzinovyev tolikzinovyev force-pushed the tolik/fix-simple-lottery branch from d212f93 to 20da78a Compare December 27, 2024 20:52
rrtoledo
rrtoledo previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

curiecrypt
curiecrypt approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@curiecrypt curiecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rrtoledo
rrtoledo approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrtoledo rrtoledo merged commit 94c7624 into main Jan 8, 2025
1 check passed
@rrtoledo rrtoledo deleted the tolik/fix-simple-lottery branch January 8, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curiecrypt curiecrypt curiecrypt approved these changes

@rrtoledo rrtoledo rrtoledo approved these changes

@djetchev djetchev Awaiting requested review from djetchev

Assignees

@tolikzinovyev tolikzinovyev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolikzinovyev @rrtoledo @curiecrypt