-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example - Centralized Telescope with BLS Signatures #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Some suggestions here and there to simplify the code (usnig type alias instead of struct, merging impl block potentially...) and make it more efficient (not using maps but sets, batching the verification).
I think the example would improve in clarity if you rename the folder "threshold_signature" "aggregate_signature" as we are only using these signature list (from registered signers) to create a threshold signature in centralized_telescope.rs. Perhaps renaming centralized_telescope.rs "centralized_threshold.rs" also?
Thanks for working on this @curiecrypt! Do you need my review or @rrtoledo and @djetchev will be enough? |
Co-authored-by: Raphael <raphael.r.toledo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I am not sure why we put tests here as this is an example but could you add asserts in each of these? We could add more tests, but let's do that in a disctint PR.
Co-authored-by: Raphael <raphael.r.toledo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Content
This PR introduces an example demonstrating the ALBA Threshold Signature scheme with the following workflow:
Workflow
nb_elements
to 1,000.soundness_param
andcompleteness_param
as 128.0.set_size
) as 80% ofnb_elements
and the lower bound as 20%.Signer
s with randomly generated keys.Registration
.IndividualSignature
s for each based on the input message.AlbaThresholdSignature
.Purpose
This example provides a detailed implementation of the ALBA Threshold Signature workflow, showcasing the integration of Telescope parameters, signer registration, individual signature generation, and threshold signature verification.
Pre-submit checklist
Issue(s)
Closes #78