Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restruct Cases #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Restruct Cases #124

wants to merge 2 commits into from

Conversation

rrtoledo
Copy link
Collaborator

@rrtoledo rrtoledo commented Jan 14, 2025 •
edited
Loading

Content

This PR includes:

  • Redefine cases as traits
  • Use cases for internal parameter initialisation

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)

Comments

Misc changes from former #66 and #116

Issue(s)

Relates to #59

@rrtoledo rrtoledo self-assigned this Jan 14, 2025
@rrtoledo rrtoledo force-pushed the raph@restruct-cases branch from af8516e to 39fd1b9 Compare January 16, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djetchev djetchev djetchev approved these changes

@tolikzinovyev tolikzinovyev Awaiting requested review from tolikzinovyev

@curiecrypt curiecrypt Awaiting requested review from curiecrypt

At least 2 approving reviews are required to merge this pull request.

Assignees

@rrtoledo rrtoledo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrtoledo @djetchev