Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CentralizedTelescope/Params: Adding unit tests #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CentralizedTelescope/Params: Adding unit tests #130

wants to merge 1 commit into from

Conversation

rrtoledo
Copy link
Collaborator

Content

This PR adds unit tests to Centralized Telescope parameter generation

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)

Comments

Issue(s)

Relates to #128

@rrtoledo rrtoledo added enhancement New feature or request P-high high priority labels Jan 21, 2025
@rrtoledo rrtoledo added this to the Centralized scheme milestone Jan 21, 2025
@rrtoledo rrtoledo self-assigned this Jan 21, 2025
@rrtoledo rrtoledo linked an issue Jan 21, 2025 that may be closed by this pull request
Add unit tests to Centralized Telescope params #128
Open
tolikzinovyev
tolikzinovyev reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@tolikzinovyev tolikzinovyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for indentation!

curiecrypt
curiecrypt approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@curiecrypt curiecrypt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Let's merge it after correcting the indentation and rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolikzinovyev tolikzinovyev tolikzinovyev left review comments

@curiecrypt curiecrypt curiecrypt approved these changes

@djetchev djetchev Awaiting requested review from djetchev

At least 2 approving reviews are required to merge this pull request.

Assignees

@rrtoledo rrtoledo

Labels
enhancement New feature or request P-high high priority
Projects
None yet
Milestone
Centralized scheme
Development

Successfully merging this pull request may close these issues.

Add unit tests to Centralized Telescope params
3 participants
@rrtoledo @tolikzinovyev @curiecrypt