Retry logic when "wheel" is not good enough #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Closed
* Also add manual serialisation of Proof + roundtrip test as it cannot be automatically derived anymore * Write a test that crashes because proof cannot be generated * Add a retryCount field for the Proof to implement the logic
Property is a bit long to run as it now needs to repeat the whole proving process several times for a small set.
Even without benchmark, it's obvious from running tests State monad will be unbearably slow
This completely ditch ST or State monad based computation which are way too expensive.
Note the test case does not actually matches the expected theoretical values. The average and max number of proof run should be 1 when n_p is greater than λ³ but it's not the case.
Also improve readability of benchmarks' label
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements retry logic as explained in the "Fixing Bad Wheels" slide:
Retry based on number of hashes works fine for "small" honest set, eg. <= λ². There's a property demonstrating empirically the mean number of retries is close to the theoretical bound (2). But it does not yield the expected number in the large set case (> λ³): The average number of retries is still high, even though the upper limit in the number of hashes is increased.