Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental commit #199

Open
6 of 12 tasks
ch1bo opened this issue Jan 30, 2022 · 32 comments
Open
6 of 12 tasks

Incremental commit #199

ch1bo opened this issue Jan 30, 2022 · 32 comments
Assignees
Labels
amber ⚠️ Medium complexity or partly unclear feature L1 Affects the on-chain protocol of Hydra L2 Affect off-chain part of the Head protocol/network 💬 feature A feature on our roadmap
Milestone

Comments

@ch1bo
Copy link
Collaborator

ch1bo commented Jan 30, 2022

Why

Hydra Heads should not need to be closed and re-opened just to add more funds. This will make Hydra Heads more flexible in enables use cases where long-living Heads are beneficial.

Furthermore, it could pave the way for getting rid of the initialization phase altogether, which would result in a much simpler protocol.

What

Implement the protocol extension for more committing additional UTXOs into a Head as already briefly described in the original Hydra Head paper.

"As user, I want to add more funds to the head, such that I can spend them later in the head"

  • When the head is open, a hydra client can request an incremental commit:

    • Requesting can be done via HTTP using the POST /commit. Just like with the "normal" commit, the user needs to send either a UTxO or a "blueprint transaction".
    • The api call is synchronous and returns a depositTx corresponding to the requested commit. (This works just the same way as the commit endpoint works so far during initialization phase)
    • Alternatively, or in addition, we provide a library to build such depositTx
  • Submitting the depositTx transaction should have the requested UTxO eventually added to the head

    • A CommitRequested (TBD: or DepositDetected?) server output is sent to signal observation of the deposit
    • The hydra-node will request inclusion of the deposited UTxO and wait for a SnapshotConfirmed with inclusion approval.
    • Using the snapshot, the creates an incrementTx, signs and submits that.
    • A CommitFinalized server output is sent to the clients when the incrementTx is observed.
  • The node provides a list of pending commits via the API using GET /commits

  • Each pending commit (deposit) has an id (i.e. the deposit outputs' TxIn) and a deadline attached, after which a user can request refund of the commit

    • Requesting can be done via HTTP using DELETE /commits/<id>, which has the node construct and submit a recoverTx for the user. TBD: okay that node pay fees here?
    • Alternatively, or in addition, we provide a library to build such a recoverTx
  • Any UTxO which can be committed, can also be incrementally committed

Scenarios

All of the positive scenarios also ensure correct balance after fanout:

  • Can commit to an open Head
    • not matter what is currently available on L2 (also empty head)
  • Can commit and immediately close with the same snapshot
  • Can do multiple increments one after another
  • Can do multiple commits and decommits in sequence as long as decommitted UTxO are consistent
  • Can commit and decommit the same UTxO should result in the same open Head UTxO
  • Cannot commit while another decommit is pending
  • Cannot decommit funds you don't own
  • Cannot commit funds you don't own
  • Can decommit everything from the Head
  • Can process L2 transactions of independent UTxO while commit is happening.
  • Cannot commit same UTxO in two Heads
    • specially in presence of rollbacks (due to network partition)
  • Can close and fanout while commit is pending
    • i.e. when someone did not submit incrementTx
    • either funds did not get committed at all or reimbursed by fanout

Security

  • The specification is updated and checked with researchers whether it is consistent with the properties above (walk-through)
  • All validator changes are tested using the mutation testing framework, covering all constraints from the specification and we saw each test "fail for the right reason", i.e. no specification change without a corresponding mutation and (at least) one mutation per constraint

Out of scope

  • Changes to the initialization of the head, see Directly open heads #1329
  • Multiple concurrent commits, i.e. there can be times when no commit is possible (yet)
  • Validator changes are audited by the internal audit team
  • Committed UTXO's are only made available in L2 if the probability of rollback is reasonably low (TODO: create orthogonal issue about rollbacks)
    • This will be a known limitation

How

Protocol design

Important

Idea: Deposit anything to commit into a deposit output. Head participants then re-use the ReqSn off-chain consensus to request inclusion of UTxO (like incremental decommit). Deposits have an asymmetric deadline, such that users need to wait longer before they can reclaim than the head participants have time to ensure the deposit is not rolled back (double spent). Deposits are recording outputs like in the commitTx and claiming a deposit into the head via an incrementTx ensures the recorded UTxO matches (completely) with what was agreed off-chain. Participants only agree off-chain if they saw a matching deposit.

Outline of one deposit being claimed in an increment and one deposit being recovered:

flowchart LR
  seed([seed])--> initTx
  initTx --> open0([open v0 η0])

  u1([u1]) --> depositTx1 --> deposit1(["deposit DL [u1]"])
  u2([u2]) --> depositTx2 --> deposit2(["deposit DL [u2]"])

  open0 -- Increment ξ3 --> incrementTx
  deposit1 -- Claim --> incrementTx
  incrementTx --> open1([open v1 η3])

  open1 -- Close ξ1 --> closeTx

  deposit2 -- Recover --> recoverTx --> u3([u2])
Loading

Protocol transitions:

  • Situation: Head is open, $U_0$ locked, off-chain busy transacting

  • Deposit:

    1. Anyone can create a deposit by posting a depositTx
      • we can enable this through hydra-node or through a library/tool.
    2. The depositTx ensures through minting of a deposit token (DT) that anything to be committed $\phi$ is recorded correctly into the datum (isomorphic to $U_\alpha$)
      • this also ensures contract continuity for next steps
      • TBD: Needed? pub key outputs need signature anyways and script outputs could inspect depositTx to ensure the transition to L2 is "correct"? Could mean more coupling, but simpler protocol here.
    3. All deposit outputs have the same address and the datum also contains target headid $\mathsf{cid}$ and a deadline $T_{DL}$
      • TBD: on commits users asked to identify heads not only by id but by participant keys, we could put them into the datum here and ensure only heads with those PTs can claim a deposit?
  • Recover:

    1. In case deposit was not picked up by a head, anyone can "undo" a commit using a recoverTx after the deadline has passed
      • most of the time, this is going to be the original user who wanted to deposit
    2. Deadline should be long enough such that the head has enough time to wait for the deposit "to settle" and still absorb it into the head (synchrony assumption on Cardano).
  • Increment:

    1. One or more Head participants (i.e. their hydra-node) observe pending deposits using the common deposit address
      • this should only happen after gaining enough confidence that the accompanying depositTx is not rolled back
      • need to check head id and deadline (should be configurable)
    2. A node requests inclusion of a pending decommit by sending a ReqSn message with $U_\alpha$
      • Not needed as every participant would observe it on-chain and its up to the snapshot leader to include it anyways
    3. The snapshot leader will request inclusion: $ReqSn(v, sn, txids, U_\alpha)$
      • Note that this submits a utxo set, not a transaction
    4. All participants acknowledge by signing this snapshot $\eta = \mathsf{combine}(\bar{U})$ and $\eta_\alpha = \mathsf{combine}(U_\alpha))$
    5. This yields a multi-signed certificate $\xi$ which can be used to post the incrementTx, which:
      • spends a deposit output, where the deposit validator ensures
        • recorded commits match $\eta_\alpha$
        • head id from datum matches (using the head state thread token)
        • deadline has not passed
      • evolves on-chain head state $(open, v, \eta)$ into updated head state $(open, v+1, \eta')$,
        • given a multi-signed certificate $\xi$ and snapshot number,
        • by verifying the signature using snapshot number, version and $\eta'$ from the head output, as well as $\eta_\alpha$ from the deposit output
    6. Head participants observe incrementTx on L1 with added $U_\alpha$ and make it available in their L2 state
      • no delay because rollbacks are impossible here -> deposit can only be spent into the head before the deadline

To be discussed

  • What happens if incrementTx is not posted after being signed on L2?

    • Any node can submit this transaction; similar situation as fanout for example
  • Do we really need to change η to be a merkle-tree-like structure with inclusion proofs?

    • Checking the value on L1 + signature on L2 would be enough, but this requires interaction with L1 when signing on L2
    • By using deposit, we can observe correct locking before requesting inclusion and our basic digest is good enough to check all-or-nothing on any individual deposit UTxO.
  • Shall we drop the initialization phase?

    • Maybe as a follow-up; Not in scope
  • How to deal with rollbacks/forward which result in a different $\eta$? When is it safe to integrate $U_\alpha$ into confirmed $U$?

    • Deadline after which a user can submit recoverTx should be >> than a safe margin on observing depositTx (e.g. deadline = 7 days, delay on deposit observe ~ 1 day); As deposits can only be spent into the head before the deadline passed, we don't need to wait when observing incrementTx
      • IMPORTANT should require a safe margin before the deadline in incrementTx (re-use contestation period?)
@ch1bo ch1bo added the 💬 feature A feature on our roadmap label Jan 30, 2022
@ch1bo ch1bo moved this to Todo in Hydra Head Roadmap Feb 2, 2022
@ch1bo ch1bo added the amber ⚠️ Medium complexity or partly unclear feature label Feb 3, 2022
@ch1bo ch1bo moved this from Next to Later in Hydra Head Roadmap Jun 1, 2022
@ch1bo ch1bo moved this to Next in Hydra Head Roadmap Jun 7, 2022
@ch1bo
Copy link
Collaborator Author

ch1bo commented Jun 14, 2022

In a discussion I had with @mchakravarty we touched on the fact that it would also be possible to directly open a head in a single transaction and do all commits incrementally after. That might lead to congestion on the state output (it's like sequential commits), but simplifies some other use cases?

@ch1bo
Copy link
Collaborator Author

ch1bo commented Jun 21, 2022

Incremental decommits may be very interesting to oracle use cases, where the resulting data is getting decomitted upon consumption.

@Yasuke
Copy link

Yasuke commented Sep 20, 2022

The use case of Incremental De/Commit really adds so much added value to many of the Use Cases that Hydra seeks solve for end-users.

From an end-users perspective, with all of the potential Heads that will be running, they will be locking funds in various places. A stake pool is well understood way of locking in funds, but with Heads, and the varied use cases, they may be more hesitant or unable (because they have commit to previous heads), to participate.

By having Incremental De/Commit users are free to allocate their funds as necessary with their goals, and feel more confident with the developers integrating features utilizing Hydra Heads.

So I see this as a very important feature for optics to the greater cardano community, and Hydra Pay would definitely be able to make good use of it.

@v0d1ch
Copy link
Contributor

v0d1ch commented Nov 21, 2022

@Sbcdn mentioned they would love to have this feature as well for their use case so +1

@ch1bo ch1bo added 💭 idea An idea or feature request and removed 💬 feature A feature on our roadmap amber ⚠️ Medium complexity or partly unclear feature labels Mar 21, 2023
@ch1bo
Copy link
Collaborator Author

ch1bo commented May 10, 2023

We discussed incremental commits/decommits (aka increments/decrements) today with the original authors of the Hydra Head paper:

  • Basically this is about adding two more transactions increment and decrement to the L1 protocol

  • Decrement requires certificate and all participants need to agree on taking
    something out of the head state

  • Sandro: This is a rough sketch/doesn't include anything related to L2
    code

  • We can start from the paper and build intuition further using knowledge from
    research team (pick their brain not do any additional work)

  • Multiple ideas to go about the increment step (original paper was not clear how $\eta$ turns into $\eta'$)

    1. we assumed we would use and require Merkle-Patricia-Trees (MPTs) for that
    2. could also use the L2 to gather a certificate for incrementing $\eta$ by some UTxO, similar to decrement step
  • Discussion pros and cons of these two approaches

    • What does this mean - request saying some participant is adding utxos?

    • Matthias: We would extend snapshots to include new information.

    • Currently, utxos are combined and hashed together for the on-chain code

    • Why MPT's? We need it in order for validator to be able to check that new state includes new utxos. We don't want to store utxo's on-chain. Could utilize inclusion proofs for the on-chain code.

    • Why would we want to use the L2 for incrementing the UTxO as well? Wouldn't everyone always agree?

      • It is likely cheaper / less work on L1
      • Requires more off-chain coordination (usual trade-off)
    • For L2 signing: we would need to sign the $\eta$, the $\eta'$ (of the latest snapshot which we expand) as well as the UTxO added/removed

      • to avoid commits you want to include may not exist anymore
      • to ensure sequencing of multiple increments
    • Isn't this interleaving state updates on the L2 with adding/removing funds from the L1?

      • Can't we do better than this combine everything approach?
      • After all, UTxO guarantee that only present outputs can be spent
  • Conclusion:

    • MPT may not strictly be required for this
    • Sandro: We should think more and not try to implement this initial brainstorm
    • Need to analyze interactions between L1/L2 to design a solution here

@ch1bo ch1bo added the L1 Affects the on-chain protocol of Hydra label Jun 20, 2023
@pgrange
Copy link
Contributor

pgrange commented Aug 22, 2023

Some use cases that we believe could benefit from this:

  • open public auctions: people should be able to join and leave the auction fluently
  • DEX: similar to auction
  • payment channels: add/retrieve funds dynamically

@ch1bo ch1bo self-assigned this Sep 4, 2023
@ch1bo
Copy link
Collaborator Author

ch1bo commented Sep 5, 2023

Notes from @mchakravarty on incremental commits and more general configuration changes (from back in the days):

Hydra Head with Incremental Commits

Requirements
Head state snapshot

  • UTxO set
  • Hash of multisig verification key (serves as a commitment to the current set of participants)
  • Sequence number (0 at initial head state; incremented with every configuration change)

Configuration change transactions

  • Configuration changes are the addition and removal of new participants as well as the committing and decommitting of funds.
  • Configuration changes are always cooperative, involving all existing participants
    • A configuration change transaction for the mainchain state machine needs to be signed by all existing participants.
    • That is, there are now two types of transactions that get multi-signed in the off-chain substrate: (1) state channel transactions and (2) configuration transactions. The former transition the off-chain UTxO set and the latter are submitted to the mainchain.
    • Like state change transactions, configuration transactions are sent by one participant p to all other participants for signing. Once fully signed, the configuration change is included into the head state snapshot and p submits the transaction to the mainchain, advancing the mainchain contract.
  • There are four types of configuration changes
    • Adding a participant
    • Removing a participant
    • Committing UTxOs to layer 2
    • Decommitting UTxOs from layer 2
  • A configuration change affects the off-chain protocol as soon as it is included in the current head state snapshot
  • Each configuration change transaction includes the head state snapshot after application of the configuration change
  • The collectCom transaction turns into configuration change 0. (But do we want it signed by everybody?)

Adding and removing participants

  • The change transaction contains the new multisig verification key.

Committing and decommitting UTxOs

  • The change transaction contains (a commitment to) the new off-chain UTxO set.

Synchronisation

  • Which configuration to use for a transaction in the off-chain is determined by the snapshot that this transaction is supposed to build on.
  • When a configuration change transaction has just been submitted or is not final on the blockchain, it may still be rolled back. In can, however, also be rolled forward again, unless all participants have also signed a competing transaction extending the mainchain or somebody decommits.
  • This raises the question of whether we need a means to contest a decommit with a configuration change. After all, the configuration change has been signed by all current participants, so it ought to be binding.

Multisigs

  • The signer set changes with adding and removing participants. What are the implications for the multisig scheme out of that?
  • Whenever the set of participants changes, the joint verification needs to be recomputed (for the new set) and needs to be committed to the mainchain contract (as part of the corresponding configuration change transaction).

@ch1bo
Copy link
Collaborator Author

ch1bo commented Sep 5, 2023

Besides the basic mermaid diagram above, here is another drawing of the potential life-cycle with incremental commits/decommits from our Miro board:

Transaction traces - Incremental commits_decommits-1.pdf

@ch1bo
Copy link
Collaborator Author

ch1bo commented Sep 5, 2023

Grooming discussion:

  • Separate increment and decrement parts (it's two user stories)
  • Same dependencies / impacts, but tackling one of the them will provide insights to the other
  • We worked on the increment part and realized we need a two-step process to avoid the problem of a commit not "being picked up". This follows the design of @mchakravarty (above) and @GeorgeFlerovsky (Hydrozoa).

Next steps:

@ch1bo ch1bo changed the title Full protocol: incremental de-/commit Incremental commit Sep 5, 2023
@ch1bo ch1bo added the L2 Affect off-chain part of the Head protocol/network label Sep 5, 2023
@ch1bo ch1bo moved this from Later to Next in Hydra Head Roadmap Sep 5, 2023
@ch1bo ch1bo added 💬 feature A feature on our roadmap amber ⚠️ Medium complexity or partly unclear feature and removed 💭 idea An idea or feature request labels Sep 20, 2023
@ch1bo ch1bo removed their assignment Nov 27, 2023
@ch1bo
Copy link
Collaborator Author

ch1bo commented Mar 6, 2024

We continued work on this after also starting #1057. We had implemented the off-chain workflow to the point of this diagram shows:

sequenceDiagram
    Alice->>+API: POST /commit (UTxO)
    API->>HeadLogic: Commit UTxO

    par broadcast
        HeadLogic->>HeadLogic: ReqInc incUTxO
    and
        HeadLogic->>Node B: ReqInc incUTxO
    end

    HeadLogic -->> Alice: WS CommitRequested

    par Alice isLeader
        HeadLogic->>HeadLogic: ReqSn incUTxO
    and
        HeadLogic->>Node B: ReqSn incUTxO
    end
    
    Note over HeadLogic,Chain: PROBLEM: Need to verify incUTxO on L1 as we authorize the TxIns to use (because of on-chain scripts).

    HeadLogic->>HeadLogic: sig = sign snapshot incl. inputs(incUTxO)

    par broadcast
        HeadLogic->>HeadLogic: AckSn sig
    and
        HeadLogic->>Node B: AckSn sig
    end

    Node B->>HeadLogic: AckSn sig

    HeadLogic -->> Alice: WS SnapshotConfirmed
    HeadLogic -->> Alice: WS CommitApproved

    HeadLogic -->> API: SnapshotConfirmed
    API->>API: draftIncrementTx vk snapshot sig >>= finalizeTx >>= signTx sk

    API-->>-Alice: IncrementTx
    Alice->>Alice: sign IncrementTx
    Alice->>Chain: submit IncrementTx
    
    Chain->>HeadLogic: OnIncrementTx
    HeadLogic-->>Alice: CommitFinalized
Loading

However, when working on the specification and trying to realize the recommendation of researchers, we hit the problem as indicated in the picture. Namely, that in one of the designs the assumption was made that Hydra participants would sign off on the transaction output references (TxOutRef) of the to-be-committed UTxO. While this would make the on-chain part fairly simply - we only need to show the out refs in the redeemer and on-chain reproduce the signed data by serializing a list of [TxOutRef], it makes the overall protocol very interactive and would require a new interaction between the protocol logic in the hydra-node and the L1 chain (query the output references before signing).

We need to discuss this and the alternative of using a Merkle-Tree based $\eta$-construction with researchers.
We now switch focus on the off-chain part on this item (as to the user, any variant would be identical) and the on-chain part of #1057 (which works on the "naiive"-$\eta$ the same as for the MT-based one) for the short term.

ch1bo added a commit that referenced this issue Jul 23, 2024
This PR adds "incremental decommits" to the Hydra Head protocol, which
allows users to take funds out of an open Head.

- New API endpoint `/decommit` which accepts a "Decommit transaction",
that spends some UTxO and whatever outputs it produces will be made
available on the L1. This can be also done through a new `Decommit`
client input and new server outputs `DecommitRequested`,
`DecommitApproved` and `DecommitFinalized`, as well as `DecommitInvalid`
to inform about status of the decommit.

- Decommits are first approved in a snapshot on L2 via a new network
message `ReqDec`, before a new `decrementTx` can be posted and observed
on-chain.

- Only one decommit can be processed at a given time.

- Update documentation and added how-to about how to use this.

- Acknowledged specification changes by "clearing" of
$\textcolor{red}{\\red}$ areas covered by this implementation in the
specification.

- End-to-end test covering the main scenario of decommitting funds.

- Added mutation tests for Decrement, Close and Contest to cover all
on-chain-verification changes.

- Enhanced `TxTrace` tests to test decrements with various snapshots and
their interaction with close/contest and fanout of a head.

---

* [x] CHANGELOG updated
* [x] Documentation updated
* [x] Haddocks updated
* [x] New TODOs explained hereafter


![image](https://github.com/user-attachments/assets/eed47f06-d519-42cb-a897-98397066fdd9)

  - Two FIXMEs covered by #1524
  - TODO in HeadLogic coverd by #1502
- TODO in tx-cost how we could improve the benchmark output (not
crucial)
- TODO in head logic about rollbacks .. actually something we need to
consider with #199 too
@ch1bo ch1bo moved this to Next in Hydra Head Roadmap Jul 23, 2024
@ch1bo
Copy link
Collaborator Author

ch1bo commented Aug 1, 2024

Got triggered by the thought that if we want to be safe properly secure Hydra Heads against rollbacks of incrementally committed funds, having full sequencing requirements + potentially long lockup times is going to be really bad. Also the UX workflow is an odd (see #199 (comment) and https://github.com/cardano-scaling/hydra/blob/f24022532cb169eb3d404e8a70362bde37a21712/docs/docs/dev/protocol.md) mix between synchronous API and asynchronous interactive rounds on the Head.

In presence of rollbacks/pessimistic settings, this is creating a Head that is not "very live" as it would need to be forced to close in case a requested to commit UTxO is spent otherwise before the incrementTx hits the chain.

A deposit based scheme (as @GeorgeFlerovsky and others have been exploring too) using a synchrony assumption where funds are locked "to get picked up" for longer than typical rollbacks occur, is much preferable in these points. While it will require two on-chain transactions to add funds to a head, we can be sure after the first deposit that any spend into the head (before a reclaim deadline) is going to still apply if rolled back. So we can employ varying strategy on timeouts between deposit (wait long) and increment (no need to wait).

Here is a drawing of this scenario:

Transaction traces - Increment_ Deposit + versioned sequential commits 2024-08-01

@noonio
Copy link
Contributor

noonio commented Aug 6, 2024

We discussed the above in grooming and realised that another validator will be needed for the deposit workflow; a minting policy, because we need to ensure that things are correctly recorded into the deposit; we will need a token on the deposit, and these can be used to discover deposits.

@GeorgeFlerovsky
Copy link

GeorgeFlerovsky commented Aug 7, 2024

We discussed the above in grooming and realised that another validator will be needed for the deposit workflow; a minting policy, because we need to ensure that things are correctly recorded into the deposit; we will need a token on the deposit, and these can be used to discover deposits.

(1) Why do you need to enforce correct deposit datum via an on-chain minting policy?

If the datum is incorrect, then the deposit can't be collected, but the user can reclaim it after deposit timeout.

(2) Doesn't that duplicate computation that occurs when collecting the commit later?

The datum needs to be inspected when checking that the head state merkel root is evolved properly, during collection.

@ch1bo
Copy link
Collaborator Author

ch1bo commented Aug 7, 2024

(1) Why do you need to enforce correct deposit datum via an on-chain minting policy?

If the datum is incorrect, then the deposit can't be collected, but the user can reclaim it after deposit timeout.

@GeorgeFlerovsky How would you know whether the datum is correct? The transaction collecting from the deposit can't inspect the output that was deposited and needs to rely that it was recorded correctly into the datum (e.g. that the right address is recorded)

Ultimately, deposit is a two step protocol and the second step needs to rely that the first step was executed correctly. Using a minting policy and a minted token for contract continuity between the two steps is the standard technique for this.

Are there other ways to ensure this?

(2) Doesn't that duplicate computation that occurs when collecting the commit later?

The datum needs to be inspected when checking that the head state merkel root is evolved properly, during collection.

In a way, yes. It requires processing the output twice, but no duplicate computation. We are not necessarily using merkle tree structures for this feature (we might switch to that for #1468), but the processing would always be two steps: serialize and digest. The plan is that the deposit transaction does only do the serialization, which would allow for easy observation and detecting of what was committed (no input resolution needed), while the increment transaction would need to create a digest that matches the multi-signed snapshot (this depends again how the L2 state is represented on L1 and how snapshots are structured)

@GeorgeFlerovsky
Copy link

GeorgeFlerovsky commented Aug 7, 2024

I guess my question is whether your onchain code should:

(A) merely check that the serialization parses into the correct type (i.e. something like { l2Addr :: Address, l2Datum :: PlutusData, l1DepositTimeout :: Slot, l1RefundAddr :: Address }); or

(B) also check that the serialization corresponds to the depositor's input utxo that provided the funds to create the deposit utxo.


Computation (A) is mandatory if your onchain code is responsible for the correct evolution of the head state hash during collection.

Computation (B) is a nice guardrail to prevent the depositor from shooting himself in the foot with a correct type but incorrect value in the deposit datum, but it incurs more fees and is not strictly necessary from the perspective of the hydra head.

@ch1bo
Copy link
Collaborator Author

ch1bo commented Aug 9, 2024

@GeorgeFlerovsky I disagree that (B) is optional, it is crucial for the correctness of any layer 2. Otherwise anyone could claim anything on the L2. While the damage is somewhat limited on value as the L1 ledger would ensure that there is enough spent into the L2, it's important that any datum is retained correctly to not break scripts when they are moved into L2.

@GeorgeFlerovsky
Copy link

@GeorgeFlerovsky I disagree that (B) is optional, it is crucial for the correctness of any layer 2. Otherwise anyone could claim anything on the L2. While the damage is somewhat limited on value as the L1 ledger would ensure that there is enough spent into the L2, it's important that any datum is retained correctly to not break scripts when they are moved into L2.

Fair enough 👍

@GeorgeFlerovsky
Copy link

GeorgeFlerovsky commented Aug 9, 2024

Although, I'm not quite sure what you mean by "anyone could claim anything on L2" and "any datum is retained correctly to not break scripts when moving to L2".

If the deposit utxo is being created from pubkey-held funds, then the deposit's L2 address and datum can be anything that the pubkey owner wants, as authorized by his signature in the tx.

If the deposit utxo is being created from script-held funds, then the deposit's L2 address and datum can be anything that the script allows in its "SendToL2" redeemer logic.

I think the difference between our views is:

  • You think of committing to a head as transferring a pre-existing utxo from L1 to become an identical utxo on L2.

  • I think of committing to a head as creating an L2 utxo from L1 funds, without necessarily requiring an identical pre-existing L1 utxo beforehand.

@ch1bo
Copy link
Collaborator Author

ch1bo commented Aug 26, 2024

@GeorgeFlerovsky When typing out the specification for the on-chain checks to be done on deposit (here) I see now more clearly what you meant:

There is no actual need for on-chain checks of what a valid deposit is (what I would have encoded in the minting policy). Anyone paying to the deposit validator (off-chain code) should ensure that what they put is a valid datum having a deadline and if a script wants to ensure continuity of its datum, it would need to green light any deposit transaction anyways.

While the interface between downstream scripts and the deposit protocol would become slightly more involved, it comes at the benefit of greatly simplifying the protocol transactions. But..

How would you describe this interface?

I was thinking something similar to the commit transaction's description: https://hydra.family/head-protocol/unstable/assets/files/hydra-spec-09c867d2d94685906cbc7a74873f9de5.pdf#subsection.5.2 but we would need to describe decoding of the recorded outputs in $C$ and check consistency with locked value off-chain?

@GeorgeFlerovsky
Copy link

@ch1bo TBH, I haven't thought too much about that interface yet.

In a hand-wavy sense, we can adapt components from what you've previously been doing for users — serializing utxos, deserializing their datum representation, comparing redeemers to hashes, etc.

We're just pushing some of those onchain/offchain mechanisms outside the hydra protocol. The onchain parts become opt-in for scripts, while pubkey users rely on the offchain checks.

@v0d1ch v0d1ch self-assigned this Sep 12, 2024
@ch1bo ch1bo moved this from Next to Now in Hydra Head Roadmap Sep 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
### Why

This is a leftover from off-chain changes needed to implement #199

We kept in the local state a map of UTxO we already observed so this
simplifies the code around that since the observed UTxO is already to be
found in the chain state UTxO. Now we keep a list of `[(TxId, UTxO)]`
where UTxO is just there to check off-chain if the next snapshot is
snapshotting exactly what we saw already as (`utxoToCommit`).

### What

Remove the local map and fields in the observations for
increment/recover and rely completely on observed UTxO (`spendableUTxO`)

---

<!-- Consider each and tick it off one way or the other -->
* [x] CHANGELOG updated or not needed
* [x] Documentation updated or not needed
* [x] Haddocks updated or not needed
* [x] No new TODOs introduced or explained herafter
@noonio noonio added this to the 0.20.0 milestone Oct 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
…mutations (#1710)

Subtask of #199

- Implement the `Claim` redeemer branch of the deposit validator.

- Add head currency symbol to the `Claim` redeemer in order to check it
against the datum value.

- Add upper validity bound for increment in order to be able to check if
the deposit deadline has not been reached.

- Double the amount of contestation period value when setting the
deposit deadline in order to give enough room for increment
to be valid (before the deadline).

- Add appropriate deposit mutations.

- Left a FIXME to not forget to fix the specification in terms of
changes in the `Claim` redeemer

---

<!-- Consider each and tick it off one way or the other -->
* [x] CHANGELOG updated or not needed
* [x] Documentation updated or not needed
* [x] Haddocks updated or not needed
* [ ] No new TODOs introduced or explained herafter
@noonio noonio removed their assignment Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amber ⚠️ Medium complexity or partly unclear feature L1 Affects the on-chain protocol of Hydra L2 Affect off-chain part of the Head protocol/network 💬 feature A feature on our roadmap
Projects
Status: Now
Development

No branches or pull requests

8 participants