Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental commits spec changes #1511

Merged

Conversation

v0d1ch
Copy link
Contributor

@v0d1ch v0d1ch commented Jul 16, 2024

#fix #1484

  • Changes in this PR introduce increment transaction and protocol changes and all relevant parts.

  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@v0d1ch v0d1ch force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from f295a37 to 09efeff Compare July 16, 2024 13:55
Copy link

github-actions bot commented Jul 16, 2024

Test Results

464 tests  ±0   457 ✅ ±0   17m 19s ⏱️ -5s
149 suites ±0     7 💤 ±0 
  5 files   ±0     0 ❌ ±0 

Results for commit 5713489. ± Comparison against base commit 30e72ea.

♻️ This comment has been updated with latest results.

@ch1bo ch1bo force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from b501851 to 1404182 Compare July 22, 2024 07:53
@ch1bo ch1bo requested a review from a team July 22, 2024 07:54
@ffakenz ffakenz force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch 2 times, most recently from 4073aa8 to 721d40a Compare July 22, 2024 11:07
@v0d1ch v0d1ch force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from e96e19c to 830d4dd Compare July 22, 2024 14:10
@cardano-scaling cardano-scaling deleted a comment from github-actions bot Jul 24, 2024
@cardano-scaling cardano-scaling deleted a comment from github-actions bot Jul 24, 2024
@cardano-scaling cardano-scaling deleted a comment from github-actions bot Jul 24, 2024
@cardano-scaling cardano-scaling deleted a comment from github-actions bot Jul 24, 2024
@cardano-scaling cardano-scaling deleted a comment from github-actions bot Jul 24, 2024
@cardano-scaling cardano-scaling deleted a comment from github-actions bot Jul 24, 2024
@ffakenz ffakenz force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from f15fd1c to 274e0b8 Compare July 24, 2024 11:23
Copy link

github-actions bot commented Jul 24, 2024

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-08-01 10:13:36.743698144 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 2fac819a1f4f14e29639d1414220d2a18b6abd6b8e444d88d0dda8ff 3799
νCommit 2043a9f1a685bcf491413a5f139ee42e335157c8c6bc8d9e4018669d 1743
νHead bd9fad235c871fb7f837c767593018a84be3083ff80f9dab5f1c55f9 10194
μHead c8038945816586c4d38926ee63bba67821eb863794220ebbd0bf79ee* 4607
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 5189 5.89 2.33 0.44
2 5389 7.27 2.88 0.47
3 5590 8.37 3.30 0.49
5 5991 11.45 4.53 0.54
10 6996 18.30 7.24 0.66
56 16246 81.43 32.21 1.76

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 556 10.52 4.15 0.29
2 748 13.86 5.65 0.34
3 937 17.33 7.20 0.38
5 1312 24.65 10.44 0.48
10 2247 45.22 19.36 0.75
20 4119 95.99 40.76 1.40

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 549 22.14 8.66 0.42
2 114 659 33.85 13.39 0.55
3 169 769 44.18 17.73 0.67
4 226 879 60.33 24.33 0.85
5 281 989 72.44 29.56 0.99
6 338 1100 91.65 37.52 1.21

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 640 17.67 7.78 0.38
2 841 20.26 9.51 0.42
3 896 20.51 10.34 0.43
5 1287 25.02 13.54 0.51
10 2062 33.46 20.37 0.66
50 7906 97.74 74.56 1.83

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 653 21.02 9.41 0.42
2 799 22.37 10.78 0.44
3 995 24.18 12.50 0.48
5 1213 27.20 15.31 0.53
10 2036 35.80 23.37 0.70
50 7965 98.58 83.12 1.90

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 689 27.18 11.69 0.48
2 851 29.28 13.50 0.52
3 940 30.60 14.65 0.54
5 1233 34.15 17.69 0.61
10 1962 43.82 25.90 0.78
39 6539 99.40 73.98 1.77

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 5055 17.36 7.55 0.57
2 5133 27.55 11.99 0.69
3 5334 42.70 18.89 0.87
4 5505 55.15 24.41 1.01
5 5562 71.30 31.55 1.20
6 5775 97.83 43.59 1.51

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 5022 7.56 3.20 0.46
5 1 57 5056 8.69 3.91 0.47
5 5 285 5193 13.21 6.75 0.53
5 10 570 5362 19.06 10.39 0.62
5 20 1139 5702 30.58 17.60 0.78
5 30 1708 6043 41.70 24.63 0.93
5 40 2273 6377 53.43 31.93 1.09
5 50 2848 6722 64.17 38.80 1.24
5 81 4611 7772 99.53 61.01 1.74

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2024-08-01 10:15:54.142590827 UTC

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 4.756986375
P99 8.865784829999907ms
P95 5.23482505ms
P50 4.0344750000000005ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 22.919258872
P99 61.90716415000018ms
P95 31.456555749999993ms
P50 20.4692045ms
Number of Invalid txs 0

@locallycompact locallycompact force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from 4de782a to f26bb6a Compare July 24, 2024 20:32
@ch1bo ch1bo force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from 159cb25 to ac7fe5c Compare July 26, 2024 07:17
Copy link
Collaborator

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some issues in the Close and off-chain. Maybe coming from the fact that things are merged into the $\theta$

testnets/cardano-configurations Outdated Show resolved Hide resolved
spec/overview.tex Outdated Show resolved Hide resolved
spec/overview.tex Outdated Show resolved Hide resolved
testnets/cardano-configurations Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/offchain.tex Outdated Show resolved Hide resolved
spec/offchain.tex Outdated Show resolved Hide resolved
spec/offchain.tex Outdated Show resolved Hide resolved
spec/fig_offchain_prot.tex Outdated Show resolved Hide resolved
@v0d1ch v0d1ch force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch 5 times, most recently from 8305282 to b28d02e Compare July 30, 2024 08:53
Copy link
Collaborator

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a lot of mistakes and inconsistencies. Please incorporate my review comments.

spec/offchain.tex Outdated Show resolved Hide resolved
spec/offchain.tex Outdated Show resolved Hide resolved
spec/offchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
Signed-off-by: Sasha Bogicevic <sasha.bogicevic@iohk.io>
@v0d1ch v0d1ch force-pushed the feature/incremental-commits-spec-and-initial-scenarios branch from ef457fe to 53867ce Compare July 31, 2024 15:26
@v0d1ch v0d1ch requested a review from ch1bo July 31, 2024 15:30
Copy link
Collaborator

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nearly finished. Only minor inconsistencies and one error to fix.

spec/macros.tex Outdated Show resolved Hide resolved
spec/onchain.tex Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/fig_offchain_prot.tex Outdated Show resolved Hide resolved
spec/fig_offchain_prot.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Outdated Show resolved Hide resolved
spec/onchain.tex Show resolved Hide resolved
Signed-off-by: Sasha Bogicevic <sasha.bogicevic@iohk.io>
spec/onchain.tex Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Nagel <ch1bo@users.noreply.github.com>
@v0d1ch v0d1ch requested a review from ch1bo August 1, 2024 10:11
@v0d1ch v0d1ch merged commit 6360171 into master Aug 1, 2024
21 checks passed
@v0d1ch v0d1ch deleted the feature/incremental-commits-spec-and-initial-scenarios branch August 1, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental commit specification & scenarios
4 participants