Introduce test prelude #53
Conversation
|
What's the rationale for another package? Wouldn't the |
|
Yes, but the converse is not true: Not all components that depend on hydra-prelude need to depend on test-related stuff like it was the case previously with |
| src | ||
| exposed-modules: | ||
| Hydra.Test.Prelude | ||
| Hydra.Network.Ports |
There was a problem hiding this comment.
Could: I would expect all modules of a package called "test-utils" to include some Test in the module name. Furthermore, other packages used in tests typically start with Test (e.g. Test.QuickCheck) and maybe we could name the prelude then also Test.Hydra.Prelude?
There was a problem hiding this comment.
Good point. I will rename the Ports module. I am fine withTest.Hydra.XXX prefix, will do that renaming too.
| import Network.WebSockets (Connection, receiveData, runClient, sendBinaryData) | ||
| import Test.Hspec | ||
| import Test.Hspec.QuickCheck (prop) | ||
| import Test.QuickCheck (cover) | ||
| import Test.QuickCheck.Monadic (monadicIO, monitor, run) | ||
| import Test.Util (failAfter, failure) | ||
| import Hydra.ServerOutput (ServerOutput (InvalidInput, ReadyToCommit)) | ||
| import Test.Util (failAfter) |
There was a problem hiding this comment.
Could: failAfter would also be a good candidate for the Test.Prelude
We provide a dedicated package for tests in order to not add more dependencies to production code when test dependencies are not needed.
Also, replace use of expectationFailure with failure which provides better error reporting.
And replace another definition of failAfter
ghost
force-pushed
the
abailly-iohk/introduce-test-prelude
branch
from
5990450 to
63e5bdc
Compare
This is a very simple PR that introduces a
hydra-test-utilspackage which exposes aHydra.Test.Preludemodule and thePortsmodule previously from hydra-prelude.I did not move code related to io-sim (from
Test.Util) but I think it would fit in there.