-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes in direct chain #666
Conversation
Test Results270 tests - 10 264 ✔️ - 10 13m 41s ⏱️ -21s Results for commit da40813. ± Comparison against base commit 42a5048. This pull request removes 11 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do not see how this is anyhow related to external commits, but okay 🤷
You somehow need an independent wallet to do that. Of course, you could have both an internal and an external wallet but it seemed to me separating the lifecycles of chain component from the wallet made sense. |
85fc0a0
to
d0ecf6e
Compare
This is needed for the case of have a single shared wallet and set of keys with multiple (virtual) nodes. Each node observes and posts tx directly to the chain independently but they share a single wallet which simplifies key handling and fuel creation.
711574a
to
da40813
Compare
This PR introduces 2 minor changes I found useful when implementing a multi-headed node:
TinyWallet
instance used byDirect
chain component outside of the call towithDirectChain
which allows the wallet to be shared by all instances ofDirect
and paves the way for an external wallet (Commit from external wallet #215)--start-chain-from 0
at startup time to the node. This useful when catching up a Hydra node esp. on testnets.To check before merging: