Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra node crashed after a fork #796

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

v0d1ch
Copy link
Contributor

@v0d1ch v0d1ch commented Mar 28, 2023

fix #560

Incorporate @ch1bo 's comments and query the cardano-node tip directly. Hopefully this prevents node crashing on rollbacks.


  • CHANGELOG updated
  • Documentation updated
  • Added and/or updated haddocks
  • No new TODOs introduced or explained herafter

@v0d1ch v0d1ch self-assigned this Mar 28, 2023
@github-actions
Copy link

Test Results

308 tests  +11   302 ✔️ +11   21m 3s ⏱️ -5s
104 suites +  4       6 💤 ±  0 
    6 files   +  1       0 ±  0 

Results for commit 2427c65. ± Comparison against base commit 79c5133.

@github-actions
Copy link

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-03-28 12:08:20.414277618 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 9492414f8f96e8483a0b8ee268fc06a954641cb2cbaa9a8b093c2c9b 4621
νCommit 5d3f107aaa56d06188cf231941cf8163e777236a9cfdc48fd4bbfa23 2422
νHead 82f16b51e2d81c6f4d42dd7398b4713a445464902f63dfd86ffe754e 8954
μHead 4083fa7081a0f4b4092fb02867c9ac594bb0e8bab8110ab242ba5a72* 4458
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 5054 13.12 5.16 0.52
2 5257 15.22 5.95 0.55
3 5464 20.31 7.97 0.61
5 5874 24.20 9.40 0.67
10 6900 35.99 13.85 0.84
36 12232 97.37 37.01 1.74

Cost of Commit Transaction

Currently only one UTxO per commit allowed (this is about to change soon)

UTxO Tx size % max Mem % max CPU Min fee ₳
1 603 15.75 6.19 0.35

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 816 24.50 9.95 0.46
2 113 1137 40.66 16.63 0.65
3 169 1460 58.95 24.26 0.87
4 227 1785 80.63 33.31 1.12

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 668 17.48 7.67 0.38
2 800 18.69 8.19 0.40
3 969 20.08 8.96 0.42
5 1300 22.57 10.38 0.46
10 2120 29.58 14.25 0.59
50 8733 86.05 45.32 1.56

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 675 21.73 9.11 0.42
2 848 23.45 9.99 0.45
3 1006 25.21 10.89 0.48
5 1335 28.63 12.66 0.53
10 2160 37.72 17.28 0.67
46 8095 99.62 49.15 1.67

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 5170 29.49 12.60 0.71
2 5491 48.00 20.73 0.93
3 5816 69.95 30.41 1.19
4 6136 95.72 41.76 1.49

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 5078 10.59 4.43 0.49
5 1 57 5113 12.12 5.31 0.51
5 5 285 5257 18.22 8.83 0.59
5 10 570 5437 25.85 13.24 0.69
5 20 1140 5793 41.11 22.05 0.90
5 30 1704 6157 56.37 30.86 1.10
5 40 2278 6519 71.64 39.68 1.30
5 50 2845 6875 86.92 48.50 1.50
5 58 3302 7164 99.14 55.56 1.67

@v0d1ch v0d1ch merged commit 2cf8aba into master Mar 29, 2023
@v0d1ch v0d1ch deleted the hydra-node-crashed-after-a-fork branch March 29, 2023 14:43
@ch1bo
Copy link
Collaborator

ch1bo commented Mar 30, 2023

@v0d1ch Please don't ignore the PR checklist. I think a changelog update for this would have been good? Also there is the "known issue" in the docs which might not be relevant anymore. Adding a note there but keeping it would be a good step here.

@v0d1ch
Copy link
Contributor Author

v0d1ch commented Mar 30, 2023

The known-issues are updated in the #795 and for the changelog I wasn't sure if I need to add anything since we are not 100% sure this fix works.

@pgrange pgrange added this to the 0.10.0 milestone May 11, 2023
@ch1bo ch1bo removed this from the 0.10.0 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra node crashed after a fork
4 participants