-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not optimize docusaurus build #880
Conversation
@ffakenz could you double check what I changed here? I'm considering that, either we're on master or not so I don't generate documentation twice, once for stable and once for unstable. But, honestly, I have no idea what impact it may have in the way we publish our doc. Did I break something? |
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
a472ca1
to
67905d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The premise of this work is very much what I thought we fix about this workflow:
- keep sanity checking of docs separate from actually creating the website, effectively using the fastest, complete build for CI
- move the building of the website into the
https://github.com/input-output-hk/hydra/actions/workflows/publish-docs.yaml
workflow- not using artifacts, but just building it twice whenever we need it built
- that is, push on
master
and push onrelease
branches for example
Instead of trying to optimize a conceptionally fragile workflow, I would suggest to move to a more robust approach first and by that, eliminate slow CI by design?
We do not optimize docusaurus build when not on master or release. We only want to sanity chack the doc and the links but do not plan to ever publish this doc. Not optimizing saves minutes. In case we're building for master or release, then, we optimize. Also, we did not need both stable/unstable versions for master so we only build the doc once.
The Documentation step was taking several minutes to optimize a web-site we will, most of the time, never publish. And, also, it was doing it twice sometimes.
So we do not generate documentation twice anymore. Also, we only generate optimized documentation for branch master and release. For all the other branches, we keep building the docusaurus stuff but only for sanity check so we don't optimize and we don't upload the artifact either.
To check that this P.R. did not break with the Publish Docs workflow, one can check this run which contains an artifact that you can download to check locally (spoiler alert: it still works): https://github.com/input-output-hk/hydra/actions/runs/5047620832