BOX-138 - card list #38

OlegBrony · 2021-06-30T18:27:36Z

in draft:

completed 141 (focus)
completed 140 (title in one line)
adds reaction on search (aka integration?)

adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61

babel plugin export ISSUES CLOSED: #61

added package from suggestions in review ISSUES CLOSED: #61

changing view for search page changes view of users list changes view of card list ISSUES CLOSED: #65

changed base button to match design ISSUES CLOSED: #65

history, reflect (has bugs) ISSUES CLOSED: #65

#65

# Conflicts: # src/app/server.tsx # src/entities/card/organisms/card-preview.tsx # src/features/search-bar/models/index.ts # src/features/search-bar/molecules/search.tsx # src/features/search-bar/organisms/search-bar.tsx # src/pages/home/index.tsx # src/pages/search/model.ts # src/pages/search/page.tsx # yarn.lock

BREAKING CHANGE: missed reflect ISSUES CLOSED: #65

# Conflicts: # .gitignore # src/pages/search/page.tsx # yarn.lock

ISSUES CLOSED: #137

ISSUES CLOSED: #138

ISSUES CLOSED: #141

…earch-fixes-card-list

# Conflicts: # src/features/search-bar/molecules/search.tsx # yarn.lock

ellips for title, fix text selection ISSUES CLOSED: #140

ellips for title, fix text selection ISSUES CLOSED: #140 ISSUES CLOSED: #91

azinit

Чет оч много всего намешал в один PR - отсюда и много правок))

Предлагаю все же изолированно сделать еще один PR касаемо CardHover и CardTitle, а здесь потом останутся только изменения связанные с search-логикой

Ну и еще оч много встретил логики в коде связанной с фокусом / логикой перемещения курсора и проч - тож надеюсь дашь коменты)

global.ignores.css

src/api/mock/fixtures.ts

src/api/mock/index.ts

src/features/search-bar/models/index.ts

src/entities/user/organisms/user-preview.tsx

src/entities/navigation/index.ts

src/entities/card/organisms/card-preview.tsx

azinit · 2021-07-05T17:29:28Z

@OlegBrony ну и это тож как бы)

ellips for title, fix text selection ISSUES CLOSED: #140 ISSUES CLOSED: #91

# Conflicts: # src/entities/card/organisms/card-preview.tsx # src/pages/home/index.tsx # src/pages/user/index.tsx

azinit · 2021-07-06T18:22:58Z

@OlegBrony спасиб что внес правки, хорошая работа)
Но как и писал - пока слишком много разнородных изменений в одном PR))

Ну т.е. я бы и не был прям сильно против, если бы ты оставил все остальные правки, но если бы ты убрал в другой PR или модуль работу с навигацией/фокусом - то можно было бы уже вливать хоть щас 🤷‍♂️

azinit

Не буду пока явно апрувить/реквестить изменения

Но чет все равно часть вещей уже согласованных - все равно здесь не поправлена)

Дай пож знать, мб ты планировал эти вещи позже сделать, я не оч помню на чем мы там в чате сошлись

azinit · 2021-07-09T15:17:32Z

src/app/custom-props.css

@@ -0,0 +1,14 @@
+:root {


Потом бы в vars.css или variables.css переименовал, но некритично)

azinit · 2021-07-09T15:19:43Z

src/entities/card/organisms/card-preview.tsx

  /**
   * @remark May be in future - make sense to split independent components - CardItem, CardDetails
-   * @default "item"
+   * @default "preview"
   */
  type?: CardType;
+  focusItemChanged?: (direction: 'next' | 'prev') => void;


Чтоб ты понимал, с чем обычно ассоциируется "preview"))

Го обратно вернем пож? (на item или синонимичное)

src/entities/card/organisms/card-preview.tsx

src/features/search-bar/models/index.ts

azinit · 2021-07-09T15:21:39Z

src/lib/use-focus.ts

+// todo:
+//  currently used only in card-list,
+//  need to optimize this hook for navigation with keyboard
+//  e.g. - handle arrow down (focus on cur item index + row len)
+export function useFocus() {
+  const containerRef = useRef<null | HTMLDivElement>(null);


Дай пож описание тогда, что делает этот хук)

azinit · 2021-07-09T15:22:41Z

src/pages/home/index.tsx

@@ -46,7 +46,7 @@ export const HomePage = () => {
          <Main>
            <CardList
              cards={cards}
-              getHref={(card) => paths.card(card.id)}
+              getHref={(card) => paths.card({ id: card.id })}


@antonmazhuto вродь не против был

Поэтому давай обратно пож вернем)

tsconfig.json

azinit

Пох, давай зальем как есть
Потом как у кого наберется сил - поправим)

А то никогда так не вольем

OlegBrony added 18 commits June 6, 2021 18:41

feat(pages/search): adds search page, adds ability to search

0ab54da

adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61

fix(pages/search): fixes empty query

945d09c

adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61

fix(pages/search): plural function

46f140f

adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61

fix(pages): suggestions from review

eda2eb8

babel plugin export ISSUES CLOSED: #61

fix(app): use-query package

bfb7e0a

added package from suggestions in review ISSUES CLOSED: #61

feat(pages): search page

8e8fbee

changing view for search page changes view of users list changes view of card list ISSUES CLOSED: #65

feat(ui/templates): header - changes color of button

d722ecf

changed base button to match design ISSUES CLOSED: #65

Merge branch 'master' into feat/61-add-search-page

574ab85

fix(app): review suggestions

3e02cd5

history, reflect (has bugs) ISSUES CLOSED: #65

fix(app): fix reflext and package

9df0245

#65

fix(app): fixed ssr for reflect in one place

bce9848

BREAKING CHANGE: missed reflect ISSUES CLOSED: #65

Merge branch 'master' into feat/61-add-search-page

c92f2df

# Conflicts: # .gitignore # src/pages/search/page.tsx # yarn.lock

fix(app): regenerate yarn lock

ba9e97f

fix(app): fixes letter dublicates in user search

0129c0c

ISSUES CLOSED: #137

fix(features): card preview - make clickable

e6dc99d

ISSUES CLOSED: #138

fix(features): card preview - make clickable

8287c51

ISSUES CLOSED: #141

Merge remote-tracking branch 'origin/feat/138-search' into feat/138-s…

9e44f4a

…earch-fixes-card-list

OlegBrony marked this pull request as draft June 30, 2021 18:27

OlegBrony added 4 commits June 30, 2021 21:28

Merge branch 'master' into feat/138-search-fixes-card-list

e31424a

# Conflicts: # src/features/search-bar/molecules/search.tsx # yarn.lock

fix(app): regenerate lock

4fb3158

fix(app): remove package lock

5fce458

fix(features): card list

6f8216b

ellips for title, fix text selection ISSUES CLOSED: #140

OlegBrony marked this pull request as ready for review July 4, 2021 17:32

feat(api): adds simulation from api - adds reaction to search params

e59f048

ellips for title, fix text selection ISSUES CLOSED: #140 ISSUES CLOSED: #91

OlegBrony requested review from azinit and sergeysova July 5, 2021 16:47

azinit suggested changes Jul 5, 2021

View reviewed changes

fix(app): changes from review

9f112f5

ellips for title, fix text selection ISSUES CLOSED: #140 ISSUES CLOSED: #91

OlegBrony added 6 commits July 5, 2021 20:55

Merge branch 'master' into feat/138-search-fixes-card-list

3b14190

# Conflicts: # src/entities/card/organisms/card-preview.tsx # src/pages/home/index.tsx # src/pages/user/index.tsx

fix(app): review changes

10f11d4

fix(app): review changes

a923c00

fix(app): review

fffdb7c

fix(app): fixed autocomplete from tsconfig|styles (glogal props)

559894e

style: move focus funcs to hook

d7ab358

risen228 previously approved these changes Jul 8, 2021

View reviewed changes

azinit reviewed Jul 9, 2021

View reviewed changes

fix(app): review

b6fd804

OlegBrony dismissed risen228’s stale review via b6fd804 July 9, 2021 17:44

OlegBrony added 2 commits July 9, 2021 22:06

fix(app): fixes card click on button

61fdd5e

fix(app): adds todo

7b96bca

azinit approved these changes Jul 9, 2021

View reviewed changes

risen228 approved these changes Jul 9, 2021

View reviewed changes

azinit merged commit 5942f87 into master Jul 11, 2021

azinit deleted the feat/138-search-fixes-card-list branch July 11, 2021 10:49

sergeysova added the feature label Oct 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BOX-138 - card list #38

BOX-138 - card list #38

OlegBrony commented Jun 30, 2021 •

edited

Loading

azinit left a comment

azinit commented Jul 5, 2021

azinit commented Jul 6, 2021

azinit left a comment

azinit Jul 9, 2021

azinit Jul 9, 2021

azinit Jul 9, 2021

azinit Jul 9, 2021

azinit left a comment

BOX-138 - card list #38

BOX-138 - card list #38

Conversation

OlegBrony commented Jun 30, 2021 • edited Loading

azinit left a comment

Choose a reason for hiding this comment

azinit commented Jul 5, 2021

azinit commented Jul 6, 2021

azinit left a comment

Choose a reason for hiding this comment

azinit Jul 9, 2021

Choose a reason for hiding this comment

azinit Jul 9, 2021

Choose a reason for hiding this comment

azinit Jul 9, 2021

Choose a reason for hiding this comment

azinit Jul 9, 2021

Choose a reason for hiding this comment

azinit left a comment

Choose a reason for hiding this comment

OlegBrony commented Jun 30, 2021 •

edited

Loading